Skip to content

Update WAFS tag and increase number of tasks for wafs_grib2_0p25#2045

Merged
KateFriedman-NOAA merged 1 commit into
NOAA-EMC:release/gfs.v16.3.11from
YaliMao-NOAA:gfs.v16.3.11_Nov8
Nov 8, 2023
Merged

Update WAFS tag and increase number of tasks for wafs_grib2_0p25#2045
KateFriedman-NOAA merged 1 commit into
NOAA-EMC:release/gfs.v16.3.11from
YaliMao-NOAA:gfs.v16.3.11_Nov8

Conversation

@YaliMao-NOAA
Copy link
Copy Markdown
Contributor

@YaliMao-NOAA YaliMao-NOAA commented Nov 8, 2023

  1. Update WAFS tag with adding forecast hour window to dbn_alert for awf and WAFS unblended hazard data

  2. Increase number of tasks for wafs_grib2_0p25

Refs #2013

Description

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES/NO
  • Does this change require a documentation update? YES/NO

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

…awf and WAFS unblended hazard data

2. Increase number of tasks for wafs_grib2_0p25
@KateFriedman-NOAA KateFriedman-NOAA self-requested a review November 8, 2023 18:56
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the production update Processing update in production label Nov 8, 2023
Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are what was discussed with NCO SPA. Thanks @YaliMao-NOAA ! Approving and then merging before cutting updated tag.

#PBS -A %PROJ%-%PROJENVIR%
#PBS -l walltime=00:30:00
#PBS -l select=1:mpiprocs=11:ompthreads=1:ncpus=11:mem=80GB
#PBS -l select=1:mpiprocs=39:ompthreads=1:ncpus=39:mem=200GB
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure NCO will ask why we are increasing this and why it is not reflected in the Release notes.
@YaliMao-NOAA Can you please justify these increases?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerorahul Xiaoxue, who is in charge of this implementation, pointed out the change that I missed in the previous PR. Should we still include in the release notes?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good idea to make a note in the release notes as we document all changes from the previous release.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KateFriedman-NOAA Sorry I didn't think about the whole situation throughly. I made another PR #2050 for the release note update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

production update Processing update in production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants