Update WAFS package by YaliMao-NOAA · Pull Request #2018 · NOAA-EMC/global-workflow

YaliMao-NOAA · 2023-11-01T22:38:23Z

Update WAFS package to produce high resolution WAFS output to meet 2023 ICAO milestone

Delay blending 0.25 trigger time by 5 minutes
Remove blending 1.25 job

Refs #2013

Description

Type of change

Bug fix (fixes something broken)
New feature (adds functionality)
Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? YES/NO
Does this change require a documentation update? YES/NO

How has this been tested?

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing tests pass with my changes
I have made corresponding changes to the documentation if necessary

… 2023 ICAO milestone 2. Update GCIP config file for NESDIS satellite upgrade

KateFriedman-NOAA

Updates look as discussed. Left comments to make a couple small changes to release notes. Will approve for merge into release branch when addressed. Thanks @YaliMao-NOAA !

aerorahul

Some comments for your consideration.

aerorahul · 2023-11-03T15:51:21Z

+Finally, NESDIS informed EMC that they will implement new global satellite composite data in Jan 2024. 
+This data set is used by one of WAFS packages. NESDIS provided a sample data set which Yali used to 
+develop an updated config file that works with current ops and to-be-implemented satellite data. 
+This updated config file will be implemented too.


Following the meeting discussion on Nov 3, the NESDIS changes are not going to be included in this release.

aerorahul · 2023-11-03T15:53:54Z

+Additionally, EMC is updating WAFS ecf definition file to 1)trigger WAFS blending job 5 min later 
+from 4:25 to 4:30 to compensate for 5-10 min delay in receiving UKMO high resolution data;
+2)stop producing blended 1.25 deg WAFS file per ICAO milestone. 
+Both sides agreed that we sill stop waiting for data from the other side at T+4:45.


Suggested change

Additionally, EMC is updating WAFS ecf definition file to 1)trigger WAFS blending job 5 min later

from 4:25 to 4:30 to compensate for 5-10 min delay in receiving UKMO high resolution data;

2)stop producing blended 1.25 deg WAFS file per ICAO milestone.

Both sides agreed that we sill stop waiting for data from the other side at T+4:45.

Additionally, EMC is updating WAFS ecf definition file to:

1. trigger WAFS blending job 5 min later from 4:25 to 4:30 to compensate for 5-10 min delay in receiving UKMO high resolution data

2. stop producing blended 1.25 deg WAFS file per ICAO milestone.

Both sides agreed that we sill stop waiting for data from the other side at T+4:45.

YaliMao-NOAA · 2023-11-03T15:59:36Z

Steven didn't approve combining WAFS blending update and GCIP parm update this morning. I am going to make the change to switch back to gfs_wafs.v6.3.1

2. Modify release note

YaliMao-NOAA · 2023-11-03T17:15:10Z

The current UK data at DCOM is /lfs/h1/ops/prod/dcom/20231103/wgrbbul/ukmet_wafs
The parallel UK data will be /lfs/h1/ops/para/dcom/20231103/wgrbbul/ukmet_wafs, which is going to be created Nov 6.

My question is how the parallel run will point to the para DCOM, not the prod DCOM. In global ecflow, which variable is controlling this?

YaliMao-NOAA · 2023-12-04T16:09:29Z

                    trigger ../../post/jgfs_atmos_post_f000 == complete
                  task jgfs_atmos_wafs_grib2_0p25
                    trigger ../../post/jgfs_atmos_post_f036 == complete
-                  task jgfs_atmos_wafs_blending


@KateFriedman-NOAA 1.25 deg WAFS blending needs to be added back for #2100

Ignore my prior reply, I see it's missing now but thankfully the ops version has it in /lfs/h1/ops/prod/packages/gfs.v16.3.11/ecf/defs/gfs_v16_3.def:

task jgfs_atmos_wafs_blending trigger ./jgfs_atmos_wafs_grib2 == complete time 04:33

@KateFriedman-NOAA That's good. Cactus hasn't synchronized gfs.v16.3.11 yet so I can't compare the file.

@YaliMao-NOAA You can compare the para install of that version on Cactus: /lfs/h1/ops/para/packages/gfs.v16.3.11/ecf/defs/gfs_v16_3.def
That's the package that was moved to prod on Dogwood.

@KateFriedman-NOAA Good. The para version on Cactus includes 1.25 deg WAFS blending. Should I withdraw PR #2113?

Should I withdraw PR #2113?

@YaliMao-NOAA Nope, all good! We were missing that change on our end so I've already merged that PR and we're good now. Thanks for catching that in our branch!

1. Update WAFS package to produce high resolution WAFS output to meet…

f3229e4

… 2023 ICAO milestone 2. Update GCIP config file for NESDIS satellite upgrade

WalterKolczynski-NOAA added the production update Processing update in production label Nov 3, 2023

KateFriedman-NOAA self-requested a review November 3, 2023 15:17

KateFriedman-NOAA suggested changes Nov 3, 2023

View reviewed changes

Comment thread docs/Release_Notes.gfs.v16.3.11.md Outdated

Comment thread docs/Release_Notes.gfs.v16.3.11.md Outdated

KateFriedman-NOAA self-assigned this Nov 3, 2023

aerorahul reviewed Nov 3, 2023

View reviewed changes

1. Removed satellite update for GCIP for this WAFS implementation

808280f

2. Modify release note

KateFriedman-NOAA approved these changes Nov 6, 2023

View reviewed changes

KateFriedman-NOAA merged commit 6cd3129 into NOAA-EMC:release/gfs.v16.3.TBD_WAFS Nov 6, 2023

YaliMao-NOAA mentioned this pull request Nov 6, 2023

WAFS update for ICAO milestone late 2023-early 2024 NOAA-EMC/WAFS#12

Closed

YaliMao-NOAA commented Dec 4, 2023

View reviewed changes

YaliMao-NOAA deleted the release/gfs.v16.3.TBD_WAFS branch March 19, 2024 17:36

Conversation

YaliMao-NOAA commented Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Change characteristics

How has this been tested?

Checklist

Uh oh!

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aerorahul left a comment

Choose a reason for hiding this comment

Uh oh!

aerorahul Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

aerorahul Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

YaliMao-NOAA commented Nov 3, 2023

Uh oh!

YaliMao-NOAA commented Nov 3, 2023

Uh oh!

YaliMao-NOAA Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

KateFriedman-NOAA Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

YaliMao-NOAA Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

KateFriedman-NOAA Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

YaliMao-NOAA Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

KateFriedman-NOAA Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YaliMao-NOAA commented Nov 1, 2023 •

edited

Loading

KateFriedman-NOAA Dec 4, 2023 •

edited

Loading