Fix IC linking in setup_expt.py#1885
Conversation
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Perfect, thanks @DavidHuber-NOAA for getting this fixed!
WalterKolczynski-NOAA
left a comment
There was a problem hiding this comment.
This is only changing the detection of whether the ICs are in the old or new COM structure. Is that all that was broken?
Yes, as originally noted here: #1529 (comment) |
|
Always happy when someone cleans up my mess. |
|
@WalterKolczynski-NOAA Yes, that is all that it fixes. A note: this does not address the case of That said, I realize now that I did not test whether this properly detects a flat structure. I will give that a quick cold start test now. |
|
Yep, all links were created successfully for a flat case. |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
|
Automated global-workflow Testing Results: |
Description
This fixes a bug in IC linking within setup_expt.py by correcting the date string based on experiment start type -- warm starts should look at
rdate(-6 hours) and cold starts should look atidate(current cycle).Fixes #1783
Type of change
Change characteristics
How has this been tested?
Tested using the
--icsdiron both warm and cold ICs on Hera. The test cases were allowed to run through the first half cycle to verify all files were linked as expected.Checklist