-
Notifications
You must be signed in to change notification settings - Fork 212
Add GEFS wave grid to scripts and ensure post runs #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
WalterKolczynski-NOAA
merged 26 commits into
NOAA-EMC:develop
from
JessicaMeixner-NOAA:gefswavegrid
May 18, 2023
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
b0a681d
adding GEFS wave grid in S2SW
NeilBarton-NOAA 38369f3
corrected commented statement
NeilBarton-NOAA 586c956
update to ww3_gint weight files for new fix directory
JessicaMeixner-NOAA 7dfb99f
Merge remote-tracking branch 'origin/newwavefix' into gefswavegrid
JessicaMeixner-NOAA 2a01e7a
keep defaults for wave as the same
JessicaMeixner-NOAA 999ddca
add gefs to sbs gridded
JessicaMeixner-NOAA c50094f
Merge remote-tracking branch 'EMC/develop' into gefswavegrid
JessicaMeixner-NOAA 00dbc36
update gridded post for gefs
JessicaMeixner-NOAA e670fbd
Merge branch 'NOAA-EMC:develop' into newwavefix
JessicaMeixner-NOAA f0504aa
update WW3 to have multiple grid setting options in config.wave
JessicaMeixner-NOAA d3bd4bd
update fix.ver for wave
JessicaMeixner-NOAA e58e5f3
Merge branch 'newwavefix' of github.com:JessicaMeixner-NOAA/global-wo…
JessicaMeixner-NOAA e38bf43
Merge remote-tracking branch 'origin/newwavefix' into gefswavegrid
JessicaMeixner-NOAA 3046684
add glo_025 to ufs
JessicaMeixner-NOAA 8533359
fix case in wave
JessicaMeixner-NOAA 6fc8d7f
add documentation
JessicaMeixner-NOAA bbd6d29
fix table in documentation
JessicaMeixner-NOAA eb76234
update documentation
JessicaMeixner-NOAA 5fcbcd9
add note about providing ICs
JessicaMeixner-NOAA 03a2d17
Merge branch 'NOAA-EMC:develop' into gefswavegrid
JessicaMeixner-NOAA 2a4c5a3
update gfs/gefs default wave grid for current v17 and v13
JessicaMeixner-NOAA 7a7db89
Update docs/source/wave.rst
JessicaMeixner-NOAA 825fbdc
Merge remote-tracking branch 'EMC/develop' into gefswavegrid
JessicaMeixner-NOAA 8217aec
update based on reviewer comments
JessicaMeixner-NOAA f2e2f95
updates for reviewer comments
JessicaMeixner-NOAA bca20e7
Merge branch 'NOAA-EMC:develop' into gefswavegrid
JessicaMeixner-NOAA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| ============== | ||
| Wave Component | ||
| ============== | ||
|
|
||
| The wave model, WAVEWATCH III, is one component of the forecast model. This documentation is a work in progress | ||
| and currently contains information about how to add a new grid to the workflow. | ||
|
|
||
| ^^^^^^^^^^^^^^^^^^^^^^ | ||
| Adding a new wave Grid | ||
| ^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| ******************** | ||
| Naming the Wave Grid | ||
| ******************** | ||
|
|
||
| The naming convention of the wave grid within the workflow is expected to follow a convention of region underscore resolution. | ||
| Here are several regional naming conventions: | ||
|
|
||
| +-----------+-----------------------+ | ||
| | Acronym | Description | | ||
| +===========+=======================+ | ||
| | glo | Global domain | | ||
| +-----------+-----------------------+ | ||
| | ak | Alaska | | ||
| +-----------+-----------------------+ | ||
| | ao or aoc | Arctic Ocean | | ||
| +-----------+-----------------------+ | ||
| | at | Atlantic | | ||
| +-----------+-----------------------+ | ||
| | ep | East Pacific | | ||
| +-----------+-----------------------+ | ||
| | gnh | Global Northern Ocean | | ||
| +-----------+-----------------------+ | ||
| | gsh | Global Southern Ocean | | ||
| +-----------+-----------------------+ | ||
| | so | Southern Ocean | | ||
| +-----------+-----------------------+ | ||
| | wc | West Coast | | ||
| +-----------+-----------------------+ | ||
|
|
||
|
|
||
| Here are examples of resolution names: | ||
|
|
||
| +---------+----------------------+ | ||
| | Acronym | Description | | ||
| +=========+======================+ | ||
| | 15m | 15 min | | ||
| +---------+----------------------+ | ||
| | 15mxt | 15 min extended grid | | ||
| +---------+----------------------+ | ||
| | 025 | 0.25 degrees | | ||
| +---------+----------------------+ | ||
| | 9km | 9 km | | ||
| +---------+----------------------+ | ||
|
|
||
| This new grid name will now be referred to as ${WAVEGRID} for the following documentation. | ||
|
|
||
| **************** | ||
| Adding Fix Files | ||
| **************** | ||
|
|
||
| The following is a table of fix files to be added with a new grid. | ||
|
|
||
| +-------------------------------------+----------------------------------------+--------------------------------------------------+ | ||
| | Name of File | File Description | Notes/Requriements | | ||
| +=====================================+========================================+==================================================+ | ||
| | ww3_grid.inp_${WAVEGRID} | Grid Input File | Required for all new grids | | ||
| +-------------------------------------+----------------------------------------+--------------------------------------------------+ | ||
| | mesh.${WAVEGRID}.nc | Mesh grid file used in forecast | This is required if this is a computational grid | | ||
| +-------------------------------------+----------------------------------------+--------------------------------------------------+ | ||
| | ww3_gint.WHTGRIDINT.bin.${WAVEGRID} | Weight file for ww3_gint interpolation | Required if output is interpolated to this grid | | ||
| +-------------------------------------+----------------------------------------+--------------------------------------------------+ | ||
|
|
||
|
|
||
| While the creation of these files are generally considered out of scope of this document here are some additional information: | ||
|
|
||
| * The ww3_grid.inp_${WAVEGRID} for structured grids can be created with https://github.com/noaA-EMC/gridgen | ||
| * The ww3_grid.inp_${WAVEGRID} file must be a single file for the workflow | ||
| * Instructions for creating mesh.${WAVEGRID}.nc can be found at https://ufs-weather-model.readthedocs.io/en/latest/InputsOutputs.html#ww3 | ||
| * The ww3_gint.WHTGRIDINT.bin.${WAVEGRID} can be created by running the ww3_gint routine as desired and then saved. | ||
|
|
||
|
JessicaMeixner-NOAA marked this conversation as resolved.
|
||
| Once the new fix files have been created, :ref:`open an issue to have the master fix file directory updated<https://github.com/NOAA-EMC/global-workflow/issues/new?assignees=KateFriedman-NOAA%2CWalterKolczynski-NOAA&labels=Fix+Files&projects=&template=fix_file.md>`. This is a separate step than the process to update the workflow below. | ||
|
|
||
| ******************************** | ||
| Updating Config and Script Files | ||
| ******************************** | ||
|
|
||
| You will need to update the following files: | ||
|
|
||
| * parm/config/*/config.ufs | ||
| * parm/config/*/config.wave | ||
| * scripts/exgfs_wave_post_gridded_sbs.sh | ||
|
|
||
| You will need to add the following files: | ||
|
|
||
| * parm/wave/ww3_grib2.${WAVEGRID}.inp.tmpl | ||
| * parm/wave/${WAVEGRID}_interp.inp.tmpl | ||
|
|
||
| For config.ufs: | ||
|
|
||
| If this is a computational you will need to update this file. If this is a new output file you can skip this update. | ||
| There are two sections to update: | ||
| 1. Add the new grid as a possible ww3 resolution at the top of the file | ||
| 2. In the WW3 specific settings section, add a case for the new grid and define ntasks_ww3 (number of tasks for WW3) and | ||
| if the grid requires a different value of nthreads_ww3 (number of threads) add that to the grid specific case as well. | ||
|
|
||
| For config.wave: | ||
|
|
||
| If this is a computational grid, add a section for the newly added grid in the possible cases for waveGRD, adding the appropriate | ||
| non-default values for this specific grid. If this is a new output grid, then update all of the waveGRD cases for waveinterpGRD as | ||
| needed. Please note that if you change the default wave grid, that initial conditions must be staged for this IC for all ICs used | ||
| in global-workflow testing. Ideally ICs for the grids being used for testing will be provided even if its not the default grid. | ||
|
|
||
|
|
||
|
|
||
| For scripts/exgfs_wave_post_gridded_sbs.sh and the inp.tmpl files: | ||
|
|
||
| There are two case settings for either interpolated grid output or grib output for a computational grid that should be updated to | ||
| add to the possible cases for this new grid as appropriate. If it's a new interpolated grid, you will also need to add a | ||
| parm/wave/${WAVEGRID}_interp.inp.tmpl file. See WW3/model/inp/ww3_gint.inp for information about this file. If it's a new | ||
| computational grid or just an output grid you will need a new parm/wave/ww3_grib2.${WAVEGRID}.inp.tmpl file. See the file | ||
| WW3/model/inp/ww3_grib.inp for more infomration about this input file. The other existing templated input files can be used | ||
| as guides to create these new files. | ||
|
|
||
|
|
||
|
|
||
|
|
||
| ***************************** | ||
| Updates for New Product Grids | ||
| ***************************** | ||
|
|
||
| If this is a new file for AWIPS Products, additional updates are likely required. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| $ WAVEWATCH-III gridded output input file | ||
| $ ---------------------------------------- | ||
| TIME DT NT | ||
| N | ||
| FLAGS | ||
| $ | ||
| TIME 7 MODNR GRIDNR 0 0 | ||
| $ | ||
| $ end of input file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.