Skip to content

Add logging level to logger #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WalterKolczynski-NOAA merged 4 commits into from
Apr 4, 2023
Merged

Add logging level to logger #1442

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ef8bd5
Logging module updates.
HenryRWinterbottom Mar 30, 2023
cf18991
Bug fixes.
HenryRWinterbottom Mar 30, 2023
7c5b334
Added logger specification via run-time environment.
HenryRWinterbottom Mar 31, 2023
f1cd6e0
Update logger.py
HenryRWinterbottom Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ush/python/pygw/src/pygw/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class Logger:
DEFAULT_FORMAT = '%(asctime)s - %(levelname)-8s - %(name)-12s: %(message)s'

def __init__(self, name: str = None,
level: str = DEFAULT_LEVEL,
level: str = None,
_format: str = DEFAULT_FORMAT,
colored_log: bool = False,
logfile_path: Union[str, Path] = None):
Expand All @@ -74,6 +74,9 @@ def __init__(self, name: str = None,
default : None
"""

if level is None:
level = os.environ.get("LOGGING_LEVEL", Logger.DEFAULT_LEVEL)

self.name = name
self.level = level.upper()
self.format = _format
Expand Down Expand Up @@ -101,7 +104,8 @@ def __init__(self, name: str = None,

# Add file handler for logger
if logfile_path is not None:
_handler = Logger.add_file_handler(logfile_path, level=self.level, _format=self.format)
_handler = Logger.add_file_handler(
logfile_path, level=self.level, _format=self.format)
self._logger.addHandler(_handler)
_handlers.append(_handler)

Expand Down Expand Up @@ -179,7 +183,8 @@ def add_stream_handler(cls, level: str = DEFAULT_LEVEL,

handler = logging.StreamHandler(sys.stdout)
handler.setLevel(level)
_format = ColoredFormatter(_format) if colored_log else logging.Formatter(_format)
_format = ColoredFormatter(
_format) if colored_log else logging.Formatter(_format)
handler.setFormatter(_format)

return handler
Expand Down