Skip to content

Minor gefs upgrade for exwave_nawips.sh to replace mv to cpfs#1367

Merged
WalterKolczynski-NOAA merged 1 commit into
NOAA-EMC:release/gefs_v12from
XianwuXue-NOAA:feature/gefs.v12.3.5
Mar 3, 2023
Merged

Minor gefs upgrade for exwave_nawips.sh to replace mv to cpfs#1367
WalterKolczynski-NOAA merged 1 commit into
NOAA-EMC:release/gefs_v12from
XianwuXue-NOAA:feature/gefs.v12.3.5

Conversation

@XianwuXue-NOAA
Copy link
Copy Markdown
Contributor

Replacing mv to cpfs to resolve mag_gefswave_processor
occasionally failed to open wave/gempak files

Change tag of GSD-prep-chem back to gefs_v12.3.3

Fixes #1366

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested by NCO on dogwood and I also ran tests on Cactus

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

Replace mv to cpfs to resolve mag_gefswave_processor
  occasionally failed to open wave/gempak files

 On branch feature/gefs.v12.3.5
	modified:   scripts/exwave_nawips.sh
	modified:   sorc/checkout.sh

Refs: NOAA-EMC#1366
@XianwuXue-NOAA
Copy link
Copy Markdown
Contributor Author

I will watch NCO's implementation, after NCO implement this change, then we can merge this change to release/gefs_v12 branch. I will also do another changes for gefs.v12.3.6 for gsd-prep-chem's changes in another PR.

Copy link
Copy Markdown
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See nothing wrong with the code, but this seems like a workaround for a different problem with an open filehandle or something. Approving since this is a change NCO is making, but someone should look for the root problem here so we can fix it correctly later.

@XianwuXue-NOAA
Copy link
Copy Markdown
Contributor Author

See nothing wrong with the code, but this seems like a workaround for a different problem with an open filehandle or something. Approving since this is a change NCO is making, but someone should look for the root problem here so we can fix it correctly later.
@WalterKolczynski-NOAA I have put some detailed info in the issue #1366. I think you may also consider to do such changes in g-w develop branch.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit c49a881 into NOAA-EMC:release/gefs_v12 Mar 3, 2023
@XianwuXue-NOAA
Copy link
Copy Markdown
Contributor Author

@WalterKolczynski-NOAA Could you delete the existing tag: gefs_v12.3.5 and then create a new tag "gefs_v12.3.5"? Thanks

@WalterKolczynski-NOAA
Copy link
Copy Markdown
Contributor

Tag updated.

@XianwuXue-NOAA XianwuXue-NOAA deleted the feature/gefs.v12.3.5 branch April 24, 2023 21:41
RussTreadon-NOAA added a commit to shlyaeva/global-workflow that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants