Skip to content

updates to use CMEPS for coupled-crow#120

Merged
jkuang-exploro merged 143 commits into
NOAA-EMC:feature/coupled-crowfrom
jiandewang:S2S-P4-CMEP
Aug 31, 2020
Merged

updates to use CMEPS for coupled-crow#120
jkuang-exploro merged 143 commits into
NOAA-EMC:feature/coupled-crowfrom
jiandewang:S2S-P4-CMEP

Conversation

@jiandewang
Copy link
Copy Markdown
Contributor

  • Updates to build and input files for using CMEPS
  • Changes mediator pet counts to only have fv3 computational cores (not the write groups)
  • updates to module files for ocean post (which now runs)
  • update to CICE5 input.nml in prep to be consistent with CICE6

JessicaMeixner-NOAA and others added 30 commits February 28, 2020 14:43
making readme consistant with user.yaml.default
…i cplwav model_config block. Reinstating config.wave block in JGLOBAL_FORECAST. Pointing EXECwave to HOMEgfs/exec directory for WW3 util executables (changed link_fv3gfs.sh accordingly). Removing debug options from compile.sh line in build_fv3.sh.
move default value into defaults/
It's better if we have one place to manage default values
for configurable variables other than two

Default values only for reference.

Please throughly test to make sure it could reproduce.
scripts update: CCPP and IPD works
add hard-coded variables into config.fcst (fcst.yaml)
ice variable istep0 bug fix
add FNMSKH conditional clause, coupled vs non-coupled
…ripts

Conflicts:
	workflow/platforms/_sandbox.yaml
JessicaMeixner-NOAA and others added 9 commits August 12, 2020 14:17
…meps

Conflicts:
	jobs/JWAVE_POST_SBS
	modulefiles/modulefile.reg2grb2.orion
	sorc/build_fv3_coupled.sh
	sorc/build_reg2grb2.sh
	ush/nems.configure.med_atm_ocn_ice_wav.IN
	ush/nems.configure.medcold_atm_ocn_ice_wav.IN
	ush/nems_configure.sh
	workflow/config/base.yaml
	workflow/config/fcst.yaml
	workflow/config/wave.yaml
	workflow/defaults/settings.yaml
	workflow/layout/free_forecast_gfs.yaml
…in workflow/platforms/orion.yaml

(2) add extra white space in ush/nems_configure.sh in line 56 to eliminate warning in run log
(3) correction on restart_n template variable setting in ush/nems.configure.med_atm_ocn_ice.IN
@jiandewang jiandewang marked this pull request as draft August 31, 2020 03:41
@jiandewang
Copy link
Copy Markdown
Contributor Author

jiandewang commented Aug 31, 2020

@JianKuang-NOAA and @JessicaMeixner-NOAA
Can you review this PR?

Thanks
Jiande

PS: Somehow I can't assign you two as reviewers by click the icon of reviewer, there is simply no icon for me to click, normally there is a round shaped icon to the right of "reviewers", don't understand why at this moment.

@jiandewang jiandewang marked this pull request as ready for review August 31, 2020 03:42
@jkuang-exploro
Copy link
Copy Markdown
Contributor

OK. I will test it.

@jkuang-exploro
Copy link
Copy Markdown
Contributor

@jiandewang It seems like this PR needs to first merge with feature/coupled-crow.

@jkuang-exploro
Copy link
Copy Markdown
Contributor

@jiandewang @JessicaMeixner-NOAA @binli2337 Also, I suggest we make every PR directly into feature/coupled-crow instead of another PR. Our PR into the trunk are supposed to be independent from each other

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Contributor

@JianKuang-NOAA I think feature/coupled-crow has already been merged in and the branch is up to date. At least that's what it tells me when trying to merge it in.

The PRs to and from these branches/PRs are because we are working in our own forks together towards the same goal. While this could probably be broken down into a few PRs, all the work is connected. I'll try to keep my work in smaller chunks in the future.

@jkuang-exploro
Copy link
Copy Markdown
Contributor

@JessicaMeixner-NOAA OK. Let me check again.

@jiandewang jiandewang changed the base branch from bugfix/coupled-crow to feature/coupled-crow August 31, 2020 14:40
@jiandewang
Copy link
Copy Markdown
Contributor Author

switch to request to merge be merged to feature/coupled-crow

@jkuang-exploro
Copy link
Copy Markdown
Contributor

@jiandewang Apologize for the confusion. Now I found that all we need is to point the destination of this PR to feature/coupled-crow instead of bugfix/coupled-crow :)

@jiandewang
Copy link
Copy Markdown
Contributor Author

@JianKuang-NOAA now we are on the same page. My branch is based on Jessica's original branch which is based on feature/coupled-crow, so there shall be no conflict.

@jiandewang
Copy link
Copy Markdown
Contributor Author

@JianKuang-NOAA the merging needs to be done by you as what I see is:
This branch has no conflicts with the base branch
Only those with write access to this repository can merge pull requests.

I guess this is why I couldn't assign reviewers in the formal way last night

@jkuang-exploro jkuang-exploro merged commit f3603c5 into NOAA-EMC:feature/coupled-crow Aug 31, 2020
zhanglikate pushed a commit to zhanglikate/global-workflow that referenced this pull request Oct 6, 2022
…c-v4 back to master (NOAA-EMC#120)

* Bugfixes for CCPP: check for and correct syntax of \htmlinclude lines
* Fix formatting (tabs, whitespaces) in tests/rt.conf
@jiandewang jiandewang deleted the S2S-P4-CMEP branch September 12, 2025 01:26
DavidHuber-NOAA pushed a commit to DavidHuber-NOAA/global-workflow that referenced this pull request Sep 12, 2025
Fix Mon_config case statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants