Skip to content

fix coding norm check in hosts.py #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WalterKolczynski-NOAA merged 2 commits into from
Dec 13, 2022
Merged

fix coding norm check in hosts.py #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c62420d
fix the norm in hosts.py after adding singularity
aerorahul Dec 13, 2022
f5366d7
ignore .git and .github dirs when checking norms
aerorahul Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pynorms.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ jobs:
- name: Run pycodestyle
run: |
cd $GITHUB_WORKSPACE/global-workflow
pycodestyle -v --config ./.pycodestyle .
pycodestyle -v --config ./.pycodestyle --exclude='.git,.github' ./
4 changes: 2 additions & 2 deletions workflow/hosts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def __init__(self, host=None):
def detect(cls):

machine = 'NOTFOUND'
container = os.getenv('SINGULARITY_NAME')
container = os.getenv('SINGULARITY_NAME', None)

if os.path.exists('/scratch1/NCEPDEV'):
machine = 'HERA'
Expand All @@ -44,7 +44,7 @@ def detect(cls):
machine = 'WCOSS2'
elif os.path.exists('/data/prod'):
machine = 'S4'
elif container != None:
elif container is not None:
machine = 'CONTAINER'

if machine not in Host.SUPPORTED_HOSTS:
Expand Down