Skip to content

Update syntax in config.ocnanalrun#1170

Closed
lgannoaa wants to merge 2 commits into
NOAA-EMC:developfrom
lgannoaa:feature/issue-1164
Closed

Update syntax in config.ocnanalrun#1170
lgannoaa wants to merge 2 commits into
NOAA-EMC:developfrom
lgannoaa:feature/issue-1164

Conversation

@lgannoaa
Copy link
Copy Markdown
Contributor

Provide update for file config.ocnanalrun to address #1164

Comment thread parm/config/config.ocnanalrun Fixed
@lgannoaa lgannoaa self-assigned this Dec 12, 2022
@aerorahul
Copy link
Copy Markdown
Contributor

Just an FYI here.
This particular violation is a bit pesky and there is no easy way to automagically fix it in a "readable" form.
The error code is SC2086

There are 2 formats that the shellchecker recognizes

$HOME/$dir/dist/bin/$file        # Unquoted (bad)
"$HOME"/"$dir"/dist/bin/"$file"  # Minimal quoting (good)
"$HOME/$dir/dist/bin/$file"      # Canonical quoting (good)

The automatic checker applies the minimal quoting, which IMHO is a bit annoying to read.
The canonical quoting makes it readable, but the auto fix does not apply it.

I think this is an eternal issue and IMO, we should disable this error code from flagging it.

@WalterKolczynski-NOAA has an issue open with shellcheck to provide an option to apply canonical fix if desired by the user.

@guillaumevernieres
Copy link
Copy Markdown
Contributor

I'm closing this PR, the issue is addressed in #1172 . Sorry @lgannoaa , I'll make sure to assign myself next time.

bbakernoaa added a commit to bbakernoaa/global-workflow that referenced this pull request Mar 19, 2026
* Update AERO_ExtData.rc for new fengsha dust input

* Brings the regression tests closer to the p8c target configuration. Changes include:
- Updating fractional clay and sand to the SOILGRIDSv2 data - REF: https://soil.copernicus.org/articles/7/217/2021/
- Silt isn't actually used in the scheme.  Set to /dev/null:0.0 to skip reading a file and instead fill with zeros
- SSM is no longer used as the albedo drag partition describes the same information to the scheme. Set to /dev/null:1.0 so that all values are unity
- `DU_RDRAG` now uses a three year climatology of the Chappel and Webb 2016 albedo drag partition derived from the latest 3 years of MODIS BRDF Albedo monthly averages
- `DU_UTHRES` now uses a more robust threshold velocity derived from known historical dust point observations using a data driven approach from the combination of a met reanalysis, SOILGRIDSv2, and a RandomForest ensemble

* Update alpha to be consistent with latest scaling 
- This updates the `alpha` parameter to be consistent with the latest dust code changes and inputs 
- Note that gamma here doesn't matter because the `ssm=1` now in the `AERO_ExtData.rc` file

* Add FSCAV_AERO for regression tests
- Adds the environment vairable FSCAV_AERO so that the wet scavaging coeffients are not by default set to zero ensuring that the convective parameterizations are fully tested when aerosols are used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants