Skip to content

Enable checking for python norms and fix violating code #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WalterKolczynski-NOAA merged 10 commits into from
Dec 12, 2022
Merged

Enable checking for python norms and fix violating code #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c5b5857
add python coding norms checking with pycodestyle
aerorahul Dec 9, 2022
a0129ee
fix scripts/exgfs_aero_init_aerosol.py
aerorahul Dec 10, 2022
af3e3b3
fix norms in ush/python/pygw
aerorahul Dec 10, 2022
d8922b3
fix norms in ush
aerorahul Dec 10, 2022
0721b4c
fix norms in test
aerorahul Dec 10, 2022
34d0069
fix norms in workflow
aerorahul Dec 10, 2022
b56a523
use checkout@v3 as per warning message from GHA
aerorahul Dec 10, 2022
47b8d2a
Merge branch 'develop' into feature/python-fix-norms
aerorahul Dec 10, 2022
5a831cb
only retain E402 (load modules at top), W504 (line continuation)
aerorahul Dec 12, 2022
1cf92f7
Merge branch 'develop' into feature/python-fix-norms
aerorahul Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/pynorms.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Check Norms
on: [push, pull_request]
Comment thread
WalterKolczynski-NOAA marked this conversation as resolved.

jobs:
check_norms:
runs-on: ubuntu-latest
name: Check Python coding norms with pycodestyle

steps:

- name: Install dependencies
run: |
pip install --upgrade pip
pip install pycodestyle

- name: Checkout
uses: actions/checkout@v3
with:
path: global-workflow

- name: Run pycodestyle
run: |
cd $GITHUB_WORKSPACE/global-workflow
pycodestyle -v --config ./.pycodestyle .
6 changes: 6 additions & 0 deletions .pycodestyle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[pycodestyle]
count = False
ignore = E402,W504
max-line-length = 160
statistics = True
exclude = Experimental
Loading