Grib2 writer for oceanicepost by AminIlia-NOAA · Pull Request #99 · NOAA-EMC/gfs-utils

AminIlia-NOAA · 2025-02-27T15:39:58Z

Description

A new grib2 writer added to oceanicepost module. It uses g2 library to build grib2 files. The module doesn't need any grib2 template. The module fully tested for ocean and ice post processing. It works smoothly and quickly.

Type of change

New feature (adds functionality)

Change characteristics

Is this a breaking change (a change in existing functionality)? YES
Does this change require a documentation update? NO

How has this been tested?

Fully tested both ocean and ice post processing modules. Grib2 files and data are generated correctly.

Checklist

[*] Any dependent changes have been merged and published
[*] My code follows the style guidelines of this project
[*] I have performed a self-review of my own code
[*] I have commented my code, particularly in hard-to-understand areas
[*] My changes generate no new warnings
[*] New and existing tests pass with my changes
[*] I have made corresponding changes to the documentation if necessary

aerorahul

Some minor comments before we can merge.

AminIlia-NOAA · 2025-02-27T22:03:02Z

@aerorahul I resolved the suggestions.

aerorahul · 2025-02-28T13:45:08Z

@aerorahul I resolved the suggestions.

@AminIlia-NOAA
Thank you for resolving the comments. I have one additional comment regarding the output in netcdf.

AminIlia-NOAA · 2025-02-28T15:20:35Z

@aerorahul added netcdf flag with default false.

aerorahul

use netcdf (we don't have to be limited to 2-3 character names) to be more descriptive.

change name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

AminIlia-NOAA · 2025-02-28T16:06:51Z

@aerorahul ncf was ok as fortran compiler mixed netcdf flag with necdf lib module. I changed the name of flag to netcdff.

aerorahul · 2025-02-28T16:11:26Z

@aerorahul ncf was ok as fortran compiler mixed netcdf flag with necdf lib module. I changed the name of flag to netcdff.

May I suggest, in that case, to replace netcdff with write_netcdf and grib2 with write_grib2.

AminIlia-NOAA · 2025-02-28T16:43:50Z

@aerorahul I changed the name of the flags. Please let me know if you want to request more change so I will give you the right access to edit my fork. Thanks!

aerorahul

looks good.

aerorahul · 2025-02-28T17:00:34Z

Since we don't have a reviewer for the new additions of grib2 output, we will merge this PR as is and if issues arise, address them during retrospective evaluation. With this change, we will disable the generation of grib2 files via the use of wgrib2.

Amin Ilia added 30 commits November 21, 2024 11:20

updated ice.csv, init_mod.f90, and ocnicepost.F90 for new grib generator

2fce5d3

initial writing of grib2 capablities

ce9825b

updates for implimmenting grib2 writer

8059745

adding grib2 2D writing capabilities to ocnicepost

fa44bef

adding grib2 2D writing capabilities to ocnicepost-fixed some issues

788826f

adding grib2 2D writing capabilities to ocnicepost-fixed issues

7d8b0a5

adding grib2 2D writing capabilities to ocnicepost-fixed issues

3f1cd1c

adding grib2 2D writing capabilities to ocnicepost-fixed more issues

73ccd1d

adding grib2 2D writing capabilities to ocnicepost-fixed one more issue

51e58b6

adding grib2 2D writing capabilities to ocnicepost-fixed typo

86972f3

adding grib2 2D writing capabilities to ocnicepost-fixed issues

069eaf5

adding grib2 2D writing capabilities to ocnicepost-fixed issues

0f75119

adding grib2 2D writing capabilities to ocnicepost-fixed issues

1d80104

adding grib2 2D writing capabilities to ocnicepost-fixed issues

5331042

adding grib2 2D writing capabilities to ocnicepost-fixed issues

f301fc9

adding grib2 2D writing capabilities to ocnicepost-fixed issues

6352c7c

implimmenting 2d grib2 writer-fixed issues

9144c52

implimmenting 2d grib2 writer-fixed issues

39089fe

modified time string for ice model temporarly

730924b

fixed unit for wrting in log file

b0eda67

fixed wrting in log file

057ab9f

fixed wrting in log file

26da8cc

fixed allocation issues

bebf1a2

fixed allocation issues

728bb0c

fixed allocation issues

7ff1c00

add stuff for debugging

23a5be5

add stuff for debugging

567dd87

add stuff for debugging

a6208cd

add stuff for debugging

038f8e9

add some command, changed grid parameters for debugging

75f5585

aerorahul requested changes Feb 27, 2025

View reviewed changes

Comment thread .vscode/settings.json Outdated

Comment thread src/ocnicepost.fd/ocnicepost.F90 Outdated

Comment thread src/ocnicepost.fd/ocnicepost.F90 Outdated

AminIlia-NOAA added 2 commits February 27, 2025 16:59

remove vscode and change file name to grb2

c3896c2

Delete .vscode directory

b1ffeb2

aerorahul reviewed Feb 28, 2025

View reviewed changes

Comment thread src/ocnicepost.fd/init_mod.F90 Outdated

added flag for netcdf files

7e46202

aerorahul requested changes Feb 28, 2025

View reviewed changes

AminIlia-NOAA and others added 10 commits February 28, 2025 10:40

Update parm/ocnicepost/ocean_mx025_to_0p25.nml

b08e44a

change name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

Update parm/ocnicepost/ocnicepost.nml.jinja2

ff070b0

change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

Update src/.gitignore

cc3b9b3

change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

Update src/ocnicepost.fd/init_mod.F90

68971dc

change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

Update parm/ocnicepost/ice_mx025_to_0p25.nml

0868587

change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

Update src/ocnicepost.fd/init_mod.F90

b8b7897

change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

Update src/ocnicepost.fd/ocnicepost.F90

ce5ae38

change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

Update src/ocnicepost.fd/ocnicepost.F90

9f9d357

change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

Update src/ocnicepost.fd/ocnicepost.F90

f84c588

change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

hange netcdf flag to netcdff

fcfd60f

AminIlia-NOAA added 2 commits February 28, 2025 11:34

change the flag names

e9c749c

change the flag names

386a0b4

aerorahul approved these changes Feb 28, 2025

View reviewed changes

aerorahul merged commit c96bbc3 into NOAA-EMC:develop Feb 28, 2025

AminIlia-NOAA deleted the grib2w branch March 6, 2025 17:35

aerorahul mentioned this pull request Mar 10, 2025

Feature/gfs utils update DavidHuber-NOAA/global-workflow#21

Merged

EricSinsky-NOAA mentioned this pull request Mar 25, 2025

Save GEFS ocn/ice products in grib2 format NOAA-EMC/global-workflow#3503

Closed

2 tasks

Conversation

AminIlia-NOAA commented Feb 27, 2025

Description

Type of change

Change characteristics

How has this been tested?

Checklist

Uh oh!

aerorahul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AminIlia-NOAA commented Feb 27, 2025

Uh oh!

Uh oh!

aerorahul commented Feb 28, 2025

Uh oh!

AminIlia-NOAA commented Feb 28, 2025

Uh oh!

aerorahul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AminIlia-NOAA commented Feb 28, 2025

Uh oh!

aerorahul commented Feb 28, 2025

Uh oh!

AminIlia-NOAA commented Feb 28, 2025

Uh oh!

aerorahul left a comment

Choose a reason for hiding this comment

Uh oh!

aerorahul commented Feb 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants