Skip to content

Add/fix build capability for Gaea-C5, Gaea-C6, and container#87

Merged
aerorahul merged 8 commits into
NOAA-EMC:developfrom
NOAA-EPIC:feature/c5c6conbuild
Dec 4, 2024
Merged

Add/fix build capability for Gaea-C5, Gaea-C6, and container#87
aerorahul merged 8 commits into
NOAA-EMC:developfrom
NOAA-EPIC:feature/c5c6conbuild

Conversation

@DavidBurrows-NCO
Copy link
Copy Markdown
Contributor

Description

After the recent Gaea-C5 OS upgrade, gfs_utils fails to build.
This corrects Gaea-C5 build, adds Gaea-C6 build capability (following ufs-wx-model 2448), and adds containerized build capability.

Refs NOAA-EMC/global-workflow 3011
Refs NOAA-EMC/global-workflow 3025
Resolve #86

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Cloned and built on Gaea-C5, Gaea-C6, and container

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Comment thread ush/module-setup.sh
Comment thread CMakeLists.txt
Comment thread modulefiles/gfsutils_generic.lua Outdated
Comment thread src/tave.fd/CMakeLists.txt
Comment thread modulefiles/gfsutils_container.intel.lua Outdated
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidBurrows-NCO can you please address some questions from the review?

Comment thread modulefiles/gfsutils_gaeac5.intel.lua Outdated
Comment thread modulefiles/gfsutils_gaeac6.intel.lua Outdated
Comment thread modulefiles/gfsutils_gaeac6.intel.lua Outdated
Comment thread modulefiles/gfsutils_gaeac6.intel.lua Outdated
Comment thread modulefiles/gfsutils_gaeac5.intel.lua Outdated
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. not sure what shellnorms is complaining about.

@aerorahul aerorahul merged commit c0b6d13 into NOAA-EMC:develop Dec 4, 2024
@DavidBurrows-NCO
Copy link
Copy Markdown
Contributor Author

Thanks, Rahul. I looked through a few times and don't see anything strange.

@DavidBurrows-NCO DavidBurrows-NCO deleted the feature/c5c6conbuild branch December 5, 2024 00:00
EricSinsky-NOAA pushed a commit to EricSinsky-NOAA/gfs-utils that referenced this pull request Mar 28, 2025
…C#87)

After the recent Gaea-C5 OS upgrade, gfs_utils fails to build.
This corrects Gaea-C5 build, adds Gaea-C6 build capability (following
ufs-wx-model
[2448](ufs-community/ufs-weather-model#2448)),
and adds containerized build capability.

Refs NOAA-EMC/global-workflow
[3011](NOAA-EMC/global-workflow#3011)
Refs NOAA-EMC/global-workflow
[3025](NOAA-EMC/global-workflow#3025)
Resolve NOAA-EMC#86 
---------

Co-authored-by: Mark A Potts <mark.potts@noaa.gov>
EricSinsky-NOAA pushed a commit to EricSinsky-NOAA/gfs-utils that referenced this pull request Jul 10, 2025
…C#87)

After the recent Gaea-C5 OS upgrade, gfs_utils fails to build.
This corrects Gaea-C5 build, adds Gaea-C6 build capability (following
ufs-wx-model
[2448](ufs-community/ufs-weather-model#2448)),
and adds containerized build capability.

Refs NOAA-EMC/global-workflow
[3011](NOAA-EMC/global-workflow#3011)
Refs NOAA-EMC/global-workflow
[3025](NOAA-EMC/global-workflow#3025)
Resolve NOAA-EMC#86 
---------

Co-authored-by: Mark A Potts <mark.potts@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gfs_utils fails to build on Gaea-C5 after OS upgrade

5 participants