Skip to content

Update gfs_bufr using the lastest version with bugzilla fix#19

Merged
KateFriedman-NOAA merged 9 commits into
NOAA-EMC:developfrom
BoCui-NOAA:develop
May 8, 2023
Merged

Update gfs_bufr using the lastest version with bugzilla fix#19
KateFriedman-NOAA merged 9 commits into
NOAA-EMC:developfrom
BoCui-NOAA:develop

Conversation

@BoCui-NOAA
Copy link
Copy Markdown
Contributor

@BoCui-NOAA BoCui-NOAA commented May 5, 2023

Update gfs_bufr.fd using the latest version of gfs-v16.
fix global-workflow issue NOAA-EMC/global-workflow#1245

Comment thread src/gfs_bufr.fd/meteorg.f Outdated
!$$$ SUBPROGRAM DOCUMENTATION BLOCK
! . . . .
! SUBPROGRAM: meteorg
! SUBPROGRAM: meteorg
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean out all of the extra whitespace that was added throughout this code? Thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, please check the latest commit. @KateFriedman-NOAA @HuiyaChuang-NOAA

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, just one last extra whitespace at the end of line 1108 in src/gfs_bufr.fd/meteorg.f. Thanks for cleaning those out, it makes it cleaner and easier to see the actual code changes now. :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

@BoCui-NOAA Please open an issue in gfs-utils to link this PR to. Within the issue's main comment please include details of what is getting updated and why. Thanks!

@BoCui-NOAA BoCui-NOAA mentioned this pull request May 5, 2023
@BoCui-NOAA
Copy link
Copy Markdown
Contributor Author

@BoCui-NOAA Please open an issue in gfs-utils to link this PR to. Within the issue's main comment please include details of what is getting updated and why. Thanks!

@KateFriedman-NOAA I opened an issue in gfs-utils, will clean out the extra white space in the code.

Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me.
I don't know how to test this, so assuming these are tested by the devs.

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

@BoCui-NOAA I ran the gfspostsnd job within the global-workflow twice...1) first with the existing gfs_utils repo execs (e.g. existing gfs_bufr) as they are in our develop branch today and then 2) again using your develop branch version from this PR. The same gfs output was used for both job runs. Please see the following output on Orion if you'd like to compare (let me know if I should transfer this output and logs to Hera):

Run 1:

Log: /work/noaa/stmp/kfriedma/comrot/devtest/logs/2022010200/gfspostsnd.log.0
/work/noaa/stmp/kfriedma/comrot/devtest/gfs.20220102/00/products/atmos/bufr_0/
/work/noaa/stmp/kfriedma/comrot/devtest/gfs.20220102/00/products/atmos/gempak_0/

Run 2:

Log: /work/noaa/stmp/kfriedma/comrot/devtest/logs/2022010200/gfspostsnd.log
/work/noaa/stmp/kfriedma/comrot/devtest/gfs.20220102/00/products/atmos/bufr/
/work/noaa/stmp/kfriedma/comrot/devtest/gfs.20220102/00/products/atmos/gempak/

@BoCui-NOAA
Copy link
Copy Markdown
Contributor Author

@KateFriedman-NOAA I compared the output files on Orion. The records are identical from the two runs. No issue was found. Thanks for running the tests.

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA I compared the output files on Orion. The records are identical from the two runs. No issue was found. Thanks for running the tests.

Thanks for checking the outputs @BoCui-NOAA ! I will proceed with approving this PR.

Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good, thanks for sending them into the gfs-utils repo @BoCui-NOAA !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants