Update gfs_bufr using the lastest version with bugzilla fix#19
Conversation
| !$$$ SUBPROGRAM DOCUMENTATION BLOCK | ||
| ! . . . . | ||
| ! SUBPROGRAM: meteorg | ||
| ! SUBPROGRAM: meteorg |
There was a problem hiding this comment.
Can you clean out all of the extra whitespace that was added throughout this code? Thanks!
There was a problem hiding this comment.
done, please check the latest commit. @KateFriedman-NOAA @HuiyaChuang-NOAA
There was a problem hiding this comment.
Much better, just one last extra whitespace at the end of line 1108 in src/gfs_bufr.fd/meteorg.f. Thanks for cleaning those out, it makes it cleaner and easier to see the actual code changes now. :)
|
@BoCui-NOAA Please open an issue in gfs-utils to link this PR to. Within the issue's main comment please include details of what is getting updated and why. Thanks! |
@KateFriedman-NOAA I opened an issue in gfs-utils, will clean out the extra white space in the code. |
aerorahul
left a comment
There was a problem hiding this comment.
looks fine to me.
I don't know how to test this, so assuming these are tested by the devs.
|
@BoCui-NOAA I ran the gfspostsnd job within the global-workflow twice...1) first with the existing gfs_utils repo execs (e.g. existing gfs_bufr) as they are in our Run 1: Run 2: |
|
@KateFriedman-NOAA I compared the output files on Orion. The records are identical from the two runs. No issue was found. Thanks for running the tests. |
Thanks for checking the outputs @BoCui-NOAA ! I will proceed with approving this PR. |
KateFriedman-NOAA
left a comment
There was a problem hiding this comment.
Updates look good, thanks for sending them into the gfs-utils repo @BoCui-NOAA !
Update gfs_bufr.fd using the latest version of gfs-v16.
fix global-workflow issue NOAA-EMC/global-workflow#1245