Skip to content

Use container with spack stack 1.9.2#128

Merged
DavidHuber-NOAA merged 31 commits into
NOAA-EMC:developfrom
NOAA-EPIC:feature/use_container_spack-stack-1.9.2
Sep 19, 2025
Merged

Use container with spack stack 1.9.2#128
DavidHuber-NOAA merged 31 commits into
NOAA-EMC:developfrom
NOAA-EPIC:feature/use_container_spack-stack-1.9.2

Conversation

@weihuang-jedi
Copy link
Copy Markdown
Collaborator

@weihuang-jedi weihuang-jedi commented Aug 21, 2025

Description

With new container has spack-stack 1.9.2, change modulefiles to use spack-stack 1.9.2 when compile in container.

Resolves #127

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? No
  • Does this change require a documentation update? NO

How has this been tested?

clone and build with shell-in singularity on AWS/Ursa.

Checklist

  • [ x] Any dependent changes have been merged and published
  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [x ] My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

weihuang-jedi and others added 26 commits April 9, 2025 23:02
@weihuang-jedi
compiled in container
6a8886e
@weihuang-jedi
change ncio, landsfcutl module places
eb7a752
@weihuang-jedi
check if it is in container
4cc1f3b
@weihuang-jedi
Merge branch 'NOAA-EMC:develop' into feature/use_container_stack-stac…
10105ab 
…k-1.6.0
@weihuang-jedi
Merge branch 'develop' of github.com:NOAA-EPIC/gfs-utils into feature…
04d56e3 
…/use_container_stack-stack-1.6.0
@weihuang-jedi
re-check inside container
abdd4e6
@weihuang-jedi
Merge branch 'feature/use_container_stack-stack-1.6.0' of ssh://githu…
5995c49 
…b.com/NOAA-EPIC/gfs-utils into feature/use_container_stack-stack-1.6.0
@weihuang-jedi
hanlde module path re-set issue in container
879e3c3
@weihuang-jedi
try to put into container
88299bd
@weihuang-jedi
sync
4516684
@weihuang-jedi
Merge branch 'NOAA-EMC:develop' into feature/use_container_stack-stac…
4078b70 
…k-1.6.0
@weihuang-jedi
Merge branch 'NOAA-EMC:develop' into feature/use_container_stack-stac…
f76028a 
…k-1.6.0
@weihuang-jedi
these two are not necessary
29d2a78
@weihuang-jedi
Merge branch 'feature/use_container_stack-stack-1.6.0' of ssh://githu…
898667b 
…b.com/NOAA-EPIC/gfs-utils into feature/use_container_stack-stack-1.6.0
@weihuang-jedi
keep gfsutils_common.lua unchanged, and set bufr in gfsutils_containe…
29bd762 
…r.intel.lua before set/load common modules
@weihuang-jedi
move the /opt check down, and also check if SINGULARITY_CONTAINER is …
141eae9 
…defined
@weihuang-jedi
Always source the lmod init script to override the system module path…
0fb1fc1 
…s and instead use the container modules
@weihuang-jedi
overwrite mahcine_id if in container, as hostname check won't be able…
86066a9 
… to find container
@weihuang-jedi
no need (cannot) load/unload gnu
7757839
@weihuang-jedi
sync
0cbdbc4
@weihuang-jedi
rename few files from .f ro .f90
f222fe5
@weihuang-jedi
keep using ifort, not ifx for now
d094132
@weihuang-jedi
Merge branch 'develop' of github.com:NOAA-EPIC/gfs-utils into feature…
e0fb12d 
…/use_container_spack-stack-1.9.2
@weihuang-jedi
update to ss192
803d9e4
@weihuang-jedi
sync with emc repo, and cleanup
66904a9
@weihuang-jedi
sync with emc repo, and cleanup
c752f9b
@weihuang-jedi weihuang-jedi mentioned this pull request Aug 21, 2025
Closed
20 tasks
@weihuang-jedi
Copy link
Copy Markdown
Collaborator Author

weihuang-jedi commented Sep 5, 2025

@DavidHuber-NOAA and @aerorahul
Could you two please review this PR?
Since this is much cleaner than ss160 container, should it be easier to review and merge?
Thanks,
Wei

@weihuang-jedi
Copy link
Copy Markdown
Collaborator Author

weihuang-jedi commented Sep 15, 2025

@DavidHuber-NOAA and @aerorahul
Could you two please review this PR?
Thanks,
Wei

DavidHuber-NOAA
DavidHuber-NOAA reviewed Sep 15, 2025
View reviewed changes
Comment thread ush/detect_machine.sh
DavidHuber-NOAA
DavidHuber-NOAA reviewed Sep 15, 2025
View reviewed changes
Comment thread ush/detect_machine.sh
aerorahul
aerorahul requested changes Sep 15, 2025
View reviewed changes
Comment thread ush/detect_machine.sh Outdated
Comment thread ush/detect_machine.sh Outdated
weihuang-jedi and others added 3 commits September 15, 2025 13:47
@weihuang-jedi @aerorahul
Update ush/detect_machine.sh
4628d6e 
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
@weihuang-jedi
Using only -v SINGULARITY_CONTAINER to check if within a container, a…
9636fe5 
…nd set MACHINE_ID to container
@weihuang-jedi
Merge branch 'feature/use_container_spack-stack-1.9.2' of github.com:…
f9faf06 
…NOAA-EPIC/gfs-utils into feature/use_container_spack-stack-1.9.2
aerorahul
aerorahul approved these changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
thanks

DavidHuber-NOAA
DavidHuber-NOAA reviewed Sep 19, 2025
View reviewed changes
Comment thread ush/detect_machine.sh
@DavidHuber-NOAA DavidHuber-NOAA merged commit 8c23465 into NOAA-EMC:develop Sep 19, 2025
3 checks passed
@weihuang-jedi
Copy link
Copy Markdown
Collaborator Author

weihuang-jedi commented Sep 19, 2025

Thank you both for reviewing and discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aerorahul aerorahul aerorahul approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use container with spack stack 1.9.2

3 participants

@weihuang-jedi @aerorahul @DavidHuber-NOAA