Fix for segmentation fault when running wave_stat.x in the global workflow#102
Merged
Merged
Conversation
Contributor
|
Excellent find @AminIlia-NOAA @sbanihash! Looking through the g2 library, I do wonder if all reals headed into g2 calls should be changed to real8 and/or if @edwardhartnett @AlexanderRichert-NOAA when interfacing with the |
12 tasks
DavidHuber-NOAA
added a commit
to NOAA-EMC/global-workflow
that referenced
this pull request
Mar 12, 2025
…n/ice post products (#3433) # Description This updates the hashes for both the UFS_Utils and GFS-utils hashes. For UFS_Utils, this is intended to update the hsi module for Gaea so that that repository will again build on that platform. The updates to GFS-utils require updates to to namelists as provided by @aerorahul. Resolves #3432 # Type of change - [x] Bug fix (fixes something broken) - [x] Maintenance (code refactor, clean-up, new CI test, etc.) # Change characteristics - Is this a breaking change (a change in existing functionality)? NO - Does this change require a documentation update? NO - Does this change require an update to any of the following submodules? YES - [x] GFS-utils NOAA-EMC/gfs-utils#102 - [x] UFS-utils ufs-community/UFS_UTILS#1031 # How has this been tested? - [x] CI testing on Hera - [x] Build tests on Gaea C6 and C5 # Checklist - [x] Any dependent changes have been merged and published - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings - [x] New and existing tests pass with my changes - [x] This change is covered by an existing CI test or a new one has been added --------- Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
guoqing-noaa
pushed a commit
to guoqing-noaa/global-workflow
that referenced
this pull request
May 29, 2025
…n/ice post products (NOAA-EMC#3433) # Description This updates the hashes for both the UFS_Utils and GFS-utils hashes. For UFS_Utils, this is intended to update the hsi module for Gaea so that that repository will again build on that platform. The updates to GFS-utils require updates to to namelists as provided by @aerorahul. Resolves NOAA-EMC#3432 # Type of change - [x] Bug fix (fixes something broken) - [x] Maintenance (code refactor, clean-up, new CI test, etc.) # Change characteristics - Is this a breaking change (a change in existing functionality)? NO - Does this change require a documentation update? NO - Does this change require an update to any of the following submodules? YES - [x] GFS-utils NOAA-EMC/gfs-utils#102 - [x] UFS-utils ufs-community/UFS_UTILS#1031 # How has this been tested? - [x] CI testing on Hera - [x] Build tests on Gaea C6 and C5 # Checklist - [x] Any dependent changes have been merged and published - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings - [x] New and existing tests pass with my changes - [x] This change is covered by an existing CI test or a new one has been added --------- Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
change single to double precision in wave_stat.f90 to fix segmentation faults. Credit to @AminIlia-NOAA for pointing out the same issue he had with oceanicepost job and how it was fixed there.
Resolves #98
Type of change
Change characteristics
How has this been tested?
Same testing as documented in issue #98 was conducted with the new wave_stat.x created after the change and the wave_stat job did not crash.
Checklist