Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] Fix 'check all' using 0-sized arrays #789

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Feb 27, 2024

Description

This PR at least partially addresses ufs-community/ufs-weather-model#2023 (at least any runtime errors associated with the CCPP). The strategy is to simply make sure that every variable is allocated, although for variables that had been conditionally-allocated to save memory, they are now being allocated with zero size. This has a ripple effect in other repos where one needs to change from checking whether a variable is allocated to whether the size is > 0.

Note: There was also some cleanup done to remove variables that are declared in GFS_ and CCPP_typedefs.F90 but are not being used anywhere anymore. In addition, the ACTIVE attribute in the metadata files was double-checked for every conditionally-allocated variable.

Issue(s) addressed

ufs-community/ufs-weather-model#2023

Testing

This was tested with the full RT suite on Hera with the -check all compilation flag added in the ufs-weather-model Intel.cmake file. All tests completed successfully with no BL changes.

Dependencies

@grantfirl
Copy link
Collaborator Author

This replaces #767 and is directed at the RRFS release branch.

@grantfirl grantfirl changed the title Feature/fix check all zero alloc rrfs Fix 'check all' using 0-sized arrays Feb 27, 2024
@grantfirl grantfirl changed the title Fix 'check all' using 0-sized arrays [production/RRFS.v1] Fix 'check all' using 0-sized arrays Feb 28, 2024
@grantfirl grantfirl changed the base branch from production/RRFS.v1 to develop March 1, 2024 15:40
@grantfirl grantfirl changed the base branch from develop to production/RRFS.v1 March 1, 2024 15:40
@grantfirl
Copy link
Collaborator Author

@jkbk2004 @MatthewPyle-NOAA This branch has been updated with the submodule pointers and should be ready to merge.

@MatthewPyle-NOAA
Copy link
Collaborator

Thanks @grantfirl - will get it merged.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 57d8e61 into NOAA-EMC:production/RRFS.v1 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants