RRTMGP refactoring#619
Merged
Merged
Conversation
…update ccpp/physics
Bugfix and optimization of prognostic closure for the P8 physics suite
37 tasks
DusanJovic-NOAA
approved these changes
Feb 1, 2023
ChunxiZhang-NOAA
approved these changes
Feb 1, 2023
Collaborator
|
@dustinswales The ccpp pr ufs-community/ccpp-physics#34 was merged. Can you update submodule pointer and revert changes in gitmodules? |
dustinswales
pushed a commit
to dustinswales/fv3atm
that referenced
this pull request
Feb 7, 2023
* Changes to typedefs for RRTMGP refactoring. Updates to prebuild and SDFs. * bugfix to save q state regardless of diagnostic flag, submodule update * optimizing massflux at cloud base based on P8 simulations, submodule update ccpp/physics * Added RRTMGP p8 coupled RT. * Move allocation of RRTMGP DDTs to init. * Removed deprecated SDFs Co-authored-by: Lisa Bengtsson <Lisa.Bengtsson@noaa.gov>
Closed
dustinswales
pushed a commit
to dustinswales/fv3atm
that referenced
this pull request
Mar 1, 2023
* Changes to typedefs for RRTMGP refactoring. Updates to prebuild and SDFs. * bugfix to save q state regardless of diagnostic flag, submodule update * optimizing massflux at cloud base based on P8 simulations, submodule update ccpp/physics * Added RRTMGP p8 coupled RT. * Move allocation of RRTMGP DDTs to init. * Removed deprecated SDFs Co-authored-by: Lisa Bengtsson <Lisa.Bengtsson@noaa.gov>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This contains changes related to uwm/ccpp-phsyics.
Testing
Tested on Cheyenne and Hera with Intel. All regression tests pass except tests with RRTMGP enabled, which need new baselines.