Added coupling of GOCART aerosols with radiation related to issue#899…

[ChunxiZhang-NOAA]

Description

The coupling between GOCART aerosols and radiation was implemented. This is a new feature.

Issue(s) addressed

Issue is described here

Dependencies

• waiting on NCAR/ccpp-physics/pull/<910>

[AnningCheng-NOAA]

looks good. Approved

[AnningCheng-NOAA]

Bc means black carbon

…

On Thu, May 5, 2022 at 10:34 AM Grant Firl ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In ccpp/data/GFS_typedefs.meta <#525 (comment)>: > + dimensions = () + type = integer +[ntss5] + standard_name = index_for_seasalt_bin5 + long_name = index for seasalt bin5 + units = index + dimensions = () + type = integer +[ntsu] + standard_name = index_for_sulfate + long_name = index for sulfate + units = index + dimensions = () + type = integer +[ntbcb] + standard_name = index_for_bcphobic I understand phobic and philic, but what does 'bc' stand for in these standard names? Can it be changed to something more descriptive for non-subject matter experts? — Reply to this email directly, view it on GitHub <#525 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQPMIJWU6Z6WYYHSB5ZKJDVIPL7NANCNFSM5UL3QXLQ> . You are receiving this because you commented.Message ID: ***@***.***>

[AnningCheng-NOAA]

On Thu, May 5, 2022 at 10:57 AM Grant Firl ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In ccpp/data/GFS_typedefs.meta <#525 (comment)>: > + dimensions = () + type = integer +[ntss5] + standard_name = index_for_seasalt_bin5 + long_name = index for seasalt bin5 + units = index + dimensions = () + type = integer +[ntsu] + standard_name = index_for_sulfate + long_name = index for sulfate + units = index + dimensions = () + type = integer +[ntbcb] + standard_name = index_for_bcphobic OK, thanks, @AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> , 'bc' is black carbon. I'm assuming 'oc' is organic carbon? Also, are the philic/phobic adjectives refering to hydrophobic/hydrophilic or some other substance? @ChunxiZhang-NOAA <https://github.com/ChunxiZhang-NOAA> Would you mind changing associated standard names since this branch is on your fork? — Reply to this email directly, view it on GitHub <#525 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQPMIIHD5D77BQZTGL3CFTVIPOW3ANCNFSM5UL3QXLQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Yes. OC is organic Carbon. The are hydrophobic and hydrophilic too.

[junwang-noaa]

gitmodule needs to be updated after the ccpp/physics is committed.

[jkbk2004]

@ChunxiZhang-NOAA can you resolve the above conversation about "bc"?

[ChunxiZhang-NOAA]

@ChunxiZhang-NOAA can you resolve the above conversation about "bc"?

@jkbk2004 done.

[jkbk2004]

@ChunxiZhang-NOAA revert gitmodule pointer and then we can merge this pr.

[jkbk2004]

@ChunxiZhang-NOAA update ccpp submodule pointer as well.

[ChunxiZhang-NOAA]

@jkbk2004 ccpp/physics submodule pointer was updated.