add NoahMP restart fix and a standalone fv3 P7 CCPP suite file #391
Merged
Conversation
This was referenced Sep 21, 2021
junwang-noaa
requested review from
DeniseWorthen,
DusanJovic-NOAA and
climbfuji
climbfuji
approved these changes
Sep 21, 2021
DeniseWorthen
approved these changes
Sep 22, 2021
Collaborator
DeniseWorthen
left a comment
DeniseWorthen
left a comment
There was a problem hiding this comment.
Perhaps we should remove the commented out line in surface_composits.
Collaborator
Author
|
@DusanJovic-NOAA would you please review? |
DusanJovic-NOAA
approved these changes
Sep 24, 2021
Collaborator
|
ccpp-physics hash is correct, ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, an fix in CCPP PR will fix the NoahMP restart issue in configuration P7 coupled tests. Also a standalone fv3 P7 CCPP suite file is also added to enable the standalone atmosphere test with P7 physics configurations.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
This fix has been tested in coupled test PR #765 on hera with C96mx100, C192mx0.5 and C384mx0.25 coupled tests
Dependencies