Regain bit-for-bit identical results between IPD and CCPP for coupled…#15
Merged
Merged
Conversation
… model runs (#86) * make rain/snow tendency consistent with accumulated rain/snow * put drain_cpl and dsnow_cpl in proper container * Updates of IPD and CCPP code to regain bit-for-bit identical results for coupled model runs * Update .gitmodules and submodule pointer for ccpp-physics for code review and testing * gfsphysics/GFS_layer/GFS_physics_driver.F90: need to initialize local variables for bit-for-bit identical results * Bugfix in gfsphysics/GFS_layer/GFS_typedefs.F90, allocate Tbd%drain_cpl and Tbd%dsnow_cpl when cplchm or cplflx is true * Remove local/interstitial variables for seaice coupling, add suite definition file for S2S benchmark runs * Rename S2S suite suite_FV3_GFS_2017_coupled_satmedmf.xml to suite_FV3_GFS_2017_satmedmf_coupled.xml * Revert change to .gitmodules and update submodule pointer for ccpp-physics Co-authored-by: Phil Pegion <38869668+pjpegion@users.noreply.github.com> Co-authored-by: Philip Pegion <Philip.Pegion@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… model runs (NOAA-EMC#86)
make rain/snow tendency consistent with accumulated rain/snow
put drain_cpl and dsnow_cpl in proper container
Updates of IPD and CCPP code to regain bit-for-bit identical results for coupled model runs
Update .gitmodules and submodule pointer for ccpp-physics for code review and testing
gfsphysics/GFS_layer/GFS_physics_driver.F90: need to initialize local variables for bit-for-bit identical results
Bugfix in gfsphysics/GFS_layer/GFS_typedefs.F90, allocate Tbd%drain_cpl and Tbd%dsnow_cpl when cplchm or cplflx is true
Remove local/interstitial variables for seaice coupling, add suite definition file for S2S benchmark runs
Rename S2S suite suite_FV3_GFS_2017_coupled_satmedmf.xml to suite_FV3_GFS_2017_satmedmf_coupled.xml
Revert change to .gitmodules and update submodule pointer for ccpp-physics
Co-authored-by: Phil Pegion 38869668+pjpegion@users.noreply.github.com
Co-authored-by: Philip Pegion Philip.Pegion@noaa.gov