fix lam post uninitialied fields#272
Merged
Merged
Conversation
1 task
WenMeng-NOAA
approved these changes
Apr 9, 2021
Contributor
WenMeng-NOAA
left a comment
WenMeng-NOAA
left a comment
There was a problem hiding this comment.
These temp fix for initializing fields like t10m looks good to me.
Collaborator
Author
|
Wen is going to have upp 10.0.6 release to fix the issues in this PR. Once upp 10.0.6 is installed on all the platforms, it will be used in this PR. |
Collaborator
Author
|
It looks to me LAM does not output this field in history file. But with
"albase=spval", sometimes I got value 0. for this field and sometimes got
different values so I made a change in inline interface to avoid the issue,
please see below. I think array grid1 in line 237 in post code FIX.F90 is
not initialized, it may need to change to:
IF(ABS(ALBASE(I,J)-SPVAL)>SMALL) then
GRID1(I,J) = ALBASE(I,J)*100.
else
GRID1(I,J) =spval
endif
< 1078:37802593:vt=2018101500:surface:anl:SNFALB Snow-Free Albedo [%]:
< ndata=53261:undef=674:mean=1.70765e+15:min=0:max=7.31e+19
---
… 1078:37762182:vt=2018101500:surface:anl:SNFALB Snow-Free Albedo [%]:
ndata=53261:undef=0:mean=0:min=0:max=0
On Thu, Apr 15, 2021 at 11:14 PM WenMeng-NOAA ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In io/post_regional.F90
<#272 (comment)>:
> @@ -641,7 +642,7 @@ subroutine set_postvars_regional(wrt_int_state,mpicomp,setvar_atmfile, &
lspa(i,j) = SPVAL
th10(i,j) = SPVAL
q10(i,j) = SPVAL
- albase(i,j) = SPVAL
+ albase(i,j) = 0.
@junwang-noaa <https://github.com/junwang-noaa> May I ask why albase is
set as 0. instead of spval?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#272 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TKERK4LZGSQ4SJR5WLTI6TQPANCNFSM42P42IEA>
.
|
Contributor
|
@junwang-noaa Got it. I will add the fix in my upcoming UPP PR which would be applied in the next upp upgrade (10.0.7 or above). |
RatkoVasic-NOAA
approved these changes
Apr 20, 2021
climbfuji
approved these changes
Apr 20, 2021
DusanJovic-NOAA
approved these changes
Apr 20, 2021
bbakernoaa
pushed a commit
to bbakernoaa/fv3atm
that referenced
this pull request
Oct 20, 2025
…rent (NOAA-EMC#272) * Modifications to replace numerous p2p transfers in fill_nested_grid_cpl by a single MPI_Bcast * Add reason for including ESMF in fv_control_init * Add code to cleanup structures associated with Bcast_comm * Use mpp_broadcast instead of MPI_Bcast at the request of NOAA-GFDL * Get rid of mpp pelist scoping calls in fill_nested_grid_cpl(). This depends on NOAA-GFDL/FMS#1246 to be functional. More efficient 'if' test in fill_nested_grid_cpl() * Bcast_comm and sending_proc variables not needed anymore * New member of the fv_atmos_type type called BcastMember allows more efficient determination of ranks involved in the mpp_broadcast call in fill_nested_grid_cpl routine * Port to FMS-2023.02 --------- Co-authored-by: Dan Kokron <Daniel.Kokron@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to fix the uninitialized fields in lam post products, and the assignment of integer fields. The uninitialized fields cause run-ro-run reproducibility issue in LAM post test.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
The code has been tested on hera and orion. The run-to-run reproducibility issue is fixed. A final solution will be initializing all the allocated fields and removing those fields in LAM post control file, which will be delivered from post group.
Dependencies
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs