Skip to content

HAFSv1: remove overwriting of time0/N for inp file #965

Merged
JessicaMeixner-NOAA merged 1 commit into
NOAA-EMC:production/hafs.v1from
JessicaMeixner-NOAA:feature/hafsfewerrestarts
Mar 31, 2023
Merged

HAFSv1: remove overwriting of time0/N for inp file #965
JessicaMeixner-NOAA merged 1 commit into
NOAA-EMC:production/hafs.v1from
JessicaMeixner-NOAA:feature/hafsfewerrestarts

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

Pull Request Summary

Removes the overwritting of the time0/N for the inp file so that restart start and end strides will be based on values chosen in the ww3_shel.inp file instead of start and end times.

Description

This is for the HAFSv1 production branch. It was requested to not write restarts every 6 hours which takes up extra disk space and possibly could effect computational time as well. In the mesh cap, the restart start and end times were over-written with start and end times which bypassed the desired restart start and end times.

Issue(s) addressed

Commit Message

Check list

n/a

Testing

  • How were these changes tested? Within HAFS system by @BinLiu-NOAA : The forecast run dir is here on Cactus:
    /lfs/h2/emc/ptmp/bin.liu/hafsv1_20230327_hfsa_dev_ww3/2021082712/09L/forecast
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) N/A
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? N/A
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.) N/A
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt): N/A

write the 1 WW3 restart file it needs, which should save disk space
as well as computational time
Copy link
Copy Markdown

@BinLiu-NOAA BinLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this for HAFSv1 package.

Copy link
Copy Markdown
Contributor

@MatthewMasarik-NOAA MatthewMasarik-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log.ww3.txt

Log file attached. Approved. Thank you, @JessicaMeixner-NOAA!

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 72875e0 into NOAA-EMC:production/hafs.v1 Mar 31, 2023
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the feature/hafsfewerrestarts branch December 12, 2023 21:27
JessicaMeixner-NOAA added a commit to JessicaMeixner-NOAA/WW3 that referenced this pull request Mar 12, 2024
* HAFSv1: remove overwriting of time0/N for inp file (NOAA-EMC#965)
* Update to ww3_bound for lon issue (fix from old hwrf branch)
* Update ww3_gint to read v16 restart
 -- added endianness to open statement in w3iorsmdold
 -- used w3iorsold for v16 from hafs branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants