HAFSv1: remove overwriting of time0/N for inp file #965
Merged
JessicaMeixner-NOAA merged 1 commit intoMar 31, 2023
Merged
Conversation
write the 1 WW3 restart file it needs, which should save disk space as well as computational time
BinLiu-NOAA
approved these changes
Mar 31, 2023
BinLiu-NOAA
left a comment
There was a problem hiding this comment.
Thanks for fixing this for HAFSv1 package.
MatthewMasarik-NOAA
approved these changes
Mar 31, 2023
Contributor
MatthewMasarik-NOAA
left a comment
There was a problem hiding this comment.
Log file attached. Approved. Thank you, @JessicaMeixner-NOAA!
JessicaMeixner-NOAA
added a commit
to JessicaMeixner-NOAA/WW3
that referenced
this pull request
Mar 12, 2024
* HAFSv1: remove overwriting of time0/N for inp file (NOAA-EMC#965) * Update to ww3_bound for lon issue (fix from old hwrf branch) * Update ww3_gint to read v16 restart -- added endianness to open statement in w3iorsmdold -- used w3iorsold for v16 from hafs branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Removes the overwritting of the time0/N for the inp file so that restart start and end strides will be based on values chosen in the ww3_shel.inp file instead of start and end times.
Description
This is for the HAFSv1 production branch. It was requested to not write restarts every 6 hours which takes up extra disk space and possibly could effect computational time as well. In the mesh cap, the restart start and end times were over-written with start and end times which bypassed the desired restart start and end times.
Issue(s) addressed
Commit Message
Check list
n/a
Testing
/lfs/h2/emc/ptmp/bin.liu/hafsv1_20230327_hfsa_dev_ww3/2021082712/09L/forecast