Skip to content

Corrections switches.json file.#814

Merged
JessicaMeixner-NOAA merged 2 commits into
NOAA-EMC:developfrom
MathieuDutSik:switches_check
Oct 5, 2022
Merged

Corrections switches.json file.#814
JessicaMeixner-NOAA merged 2 commits into
NOAA-EMC:developfrom
MathieuDutSik:switches_check

Conversation

@MathieuDutSik

Copy link
Copy Markdown
Contributor

Pull Request Summary

A few corrections to the switches.json file.

Description

Only two small corrections are done.

Issue(s) addressed

No issues had been created on that problem.

Commit Message

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@MatthewMasarik-NOAA

Copy link
Copy Markdown
Contributor

Hi @MathieuDutSik , great catch! Could you bring your branch up to date with develop? I'll start running the tests then.

@MathieuDutSik

Copy link
Copy Markdown
Contributor Author

Hi @MathieuDutSik , great catch! Could you bring your branch up to date with develop? I'll start running the tests then.

Thanks, done.

@MatthewMasarik-NOAA

Copy link
Copy Markdown
Contributor

Great, thank you @MathieuDutSik . I'll run the regression tests.

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MathieuDutSik thanks for the fixes!

Expected regtest diffs:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (19 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
ww3_ta1/./work_UPD0F_U                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.17/./work_a                     (1 files differ)
ww3_tp2.17/./work_c                     (1 files differ)
ww3_tp2.17/./work_b                     (1 files differ)
ww3_tp2.6/./work_ST0                     (1 files differ)
ww3_tp2.6/./work_ST4                     (1 files differ)
ww3_tp2.6/./work_pdlib                     (1 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 31a7164 into NOAA-EMC:develop Oct 5, 2022
@MathieuDutSik MathieuDutSik deleted the switches_check branch October 20, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants