Fix for inconsistent time in air density input#812
Merged
MatthewMasarik-NOAA merged 2 commits intoOct 3, 2022
Conversation
ukmo-juan-castillo
requested review from
JessicaMeixner-NOAA and
ukmo-ccbunney
Collaborator
|
Changes look good to me. I am running the regressions tests. |
Collaborator
|
Regression tests passed ok, just the usual suspects not B4B |
Contributor
|
Hi @ukmo-juan-castillo , thank you for this pull request! I've started running the regressions tests on our end. @JessicaMeixner-NOAA is out today, but will return on Monday and we will finalize this PR at that time. |
MatthewMasarik-NOAA
approved these changes
Oct 3, 2022
Contributor
There was a problem hiding this comment.
regression tests passed on hera with the known non-identicals + unstructured mod_defs.
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UNO_MPI_d2 (10 files differ)
mww3_test_03/./work_PR1_MPI_d2 (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (12 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (15 files differ)
ww3_ta1/./work_UPD0F_U (0 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.16/./work_MPI_OMPH (4 files differ)
ww3_tp2.17/./work_ma (1 files differ)
ww3_tp2.17/./work_mc1 (1 files differ)
ww3_tp2.17/./work_mb (1 files differ)
ww3_tp2.17/./work_mc (1 files differ)
ww3_tp2.17/./work_ma1 (1 files differ)
ww3_tp2.6/./work_ST0 (1 files differ)
ww3_tp2.6/./work_ST4 (1 files differ)
ww3_tp2.6/./work_pdlib (1 files differ)
ww3_ufs1.3/./work_a (1 files differ)
**********************************************************************
************************ identical cases *****************************
**********************************************************************
Contributor
|
Thanks again for your work, @ukmo-juan-castillo ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Fix inconsistent time check in air density input
Description
f driving data is read from file, the consistency of the times in the file is checked in the W3WAVE subroutine. This is done to make sure that the driving data contains valid data for the time of the run. In the case of air density, the times read from the momentum driving data file are used, which is wrong and can cause false errors. To fix the problem, the variables TR0 and TRN have to be used instead of TU0 and TUN when testing the air density file, which should be evident by reading the code with care.
No change in answers in expected, although configurations using as driving data air density but not momentum will now not fail if set correctly.
Labels that should be added: bug
Issue(s) addressed
Commit Message
Fix for inconsistent time check in air density input
Check list
Testing
Regtests, and the amm15-smc configuration at the Met Office driven by air density.
Not covered, and not vital to have it added. Usually, when driving the model with air density the user would like to drive it with momentum too, so the configuration that is failing will not typically be used.
Yes, on the CrayXC40 at the Met Office using the GNU compiler.
No changes expected
See comment below.