Some correction for the exchange.#805
Merged
JessicaMeixner-NOAA merged 1 commit intoSep 27, 2022
Merged
Conversation
Collaborator
|
@MathieuDutSik thanks for the PR! I'm running regtests for another PR right now, and then will start regtests for this PR. I'll keep you up to date if any issues are encountered. |
JessicaMeixner-NOAA
approved these changes
Sep 27, 2022
Collaborator
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
matrixDiff.txt
matrixCompFull.txt
matrixCompSummary.txt
Only expected non-identical cases:
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (18 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (18 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR1_MPI_d2 (18 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (13 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (18 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (17 files differ)
ww3_ta1/./work_UPD0F_U (0 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.16/./work_MPI_OMPH (4 files differ)
ww3_tp2.17/./work_mb (1 files differ)
ww3_tp2.17/./work_b (1 files differ)
ww3_tp2.17/./work_mc (1 files differ)
ww3_tp2.17/./work_a (1 files differ)
ww3_tp2.17/./work_c (1 files differ)
ww3_tp2.17/./work_ma (1 files differ)
ww3_tp2.17/./work_mc1 (1 files differ)
ww3_tp2.17/./work_ma1 (1 files differ)
ww3_ufs1.3/./work_a (1 files differ)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
The exchange mechanism is replaced which leads to avoiding creating an intermediate array
and so a decrease of memory expense.
Description
The PDLIB_exchange2Dreal is replaced by PDLIB_exchange2Dreal_zero.
Issue(s) addressed
The previous exchange forces the creation of an intermediate array which is of large size because
it is about VA. The PR decreases memory expenses and is thus a progress.
Commit Message
Reduce memory usage of PDLIB_exchange in wminiomd.F90
Check list
Testing