Doxygen marked source - PR3#748
Merged
Merged
Conversation
Conflicts: model/src/constants.F90
Contributor
|
@ukmo-ccbunney @mickaelaccensi We are seeing differences in the file OUTPUT_TOY.txt in test ww3_tp2.14/./work_OASICM below differs by one line of text, APPLE partitioning. Could you take a look and let us know if you know why it happens? This PR is for deoxygenizing the modules and routines. |
Contributor
|
I ran the regtests twice and did not encounter the same issue @MatthewMasarik-NOAA have seen, so I approve this PR and proceed with the merge. |
aliabdolali
approved these changes
Aug 9, 2022
kestonsmith-noaa
pushed a commit
to kestonsmith-noaa/WW3
that referenced
this pull request
Jun 17, 2025
* This PR addresses part 2 of issue NOAA-EMC#748 to activate the exponential-random cloud overlap method (iovr=5) in RRTMG. RT tests were added for iovr=4 and iovr=5 options * change iovr to use the environment variable in control.nml.IN; modify all tests that use control.nml.IN to set env. var. iovr=3 (except for new tests); remove restart files from new tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Collection of
doxygenmarked files.Description
The following list of files has been marked with
doxygentags for documentation:Is a change of answers expected from this PR?
No. Documentation only added. However, there is one small change described below.
Please also include the following information:
Issue(s) addressed
Commit Message
Doxygen documentation - marked source PR 3
Co-author: @JessicaMeixner-NOAA
Check list
Testing
How were these changes tested?
#ifdefblock. The block toggles optional input to a subroutine call in w3wavemd.F90 and may be difficult to remove entirely.)Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
No. The changes are only documentation. Documentation is not tested.
Have the matrix regression tests been run (if yes, please note HPC and compiler)?
Yes. Hera / Intel.
Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
No expected changes except for the known non-identical tests and unstructured grid mod_defs. That said, there is one change to a text log file mentioned below.
Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
Note: the file
OUTPUT_TOY.txtin the testww3_tp2.14/./work_OASICMbelow differs by one line of text,APPLE partitioning. The repo under review contains this line as shown in the screenshot below, whereas the same file in the develop branch does not have it at this location. Both files do have the same line appearing lower down in the file. This is the third time matrix has been run, and each time the same result.matrixDiff.txt
matrixCompSummary.txt
matrixCompFull.txt
new.OUTPUT_TOY.txt
dev.OUTPUT_TOY.txt