Default endian

[ukmo-ccbunney]

Pull Request Summary

Added CPP directives to set default value for ENDIANNESS in constants.f90 if not defined by build system.
Default value is "native".

Please also include the following information:

• Add any suggestions for a reviewer @aronroland @JessicaMeixner-NOAA
• Are answer changes expected from this PR? No changes expected.

Issue(s) addressed

• fixes Syntax Error "error #6592: This symbol must be a defined parameter, an enumerator, or an argument of an inquiry function that evaluates to a compile-time constant. [ENDIANNESS] character(*), parameter :: FILE_ENDIAN = ENDIANNESS #742

Commit Message

Set default ENDIANNESS="native" in constants.F90

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• [N/A] If a version number update is required, checked the updating version number checklist.
• [N/A] If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? Regtests
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? Yes
• Please indicate the expected changes in the regression test output: No changes expected.
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

Regtests show only the known differences

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (19 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (18 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)

[JessicaMeixner-NOAA]

Testing on my end now. Thanks @ukmo-ccbunney for providing this update!

[aliabdolali]

@aronroland could you check and let me know if this fixes your problem?

[JessicaMeixner-NOAA]

Regtests are as expected on NCEP machines:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
ww3_ta1/./work_UPD0F_U                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.17/./work_a                     (1 files differ)
ww3_tp2.17/./work_c                     (1 files differ)
ww3_tp2.17/./work_b                     (1 files differ)
ww3_tp2.6/./work_ST0                     (1 files differ)
ww3_tp2.6/./work_ST4                     (1 files differ)
ww3_tp2.6/./work_pdlib                     (1 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

The normal + unstructured grid mod_defs.

[aliabdolali]

I reviewed it, thanks Chris for doing it. Aron approved the PR as well.