Bugfix/gmake endian

[ukmo-ccbunney]

Pull Request Summary

Fixes broken gmake build after PR #680

Description

The gmake build is broken after PR #680 - the ENDIANNESS string is not being replaced by the pre-processor in constants.ftn.

This PR adds a choice of endian in the cmplr.env file. I have set this to default to "native".
I have removed instances of compiler flags that set the endianness and have set this via the new endian environment variable in cmplr.env instead.

No changes are expected in the output files or regression tests.

Issue(s) addressed

• fixes GMAKE build failing after #680 #720

Commit Message

Added choice of endian for binaray I/O when building with gmake

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? Regtests
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) No
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? Cray HPC; GNU Fortran

Regtest results

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_02/./work_PR2_UNO_MPI_c                     (53 files differ)
mww3_test_02/./work_PR2_UNO_MPI_d                     (3 files differ)
mww3_test_02/./work_PR2_UNO_MPI_b                     (53 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (9 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (10 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (11 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (10 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)

mww3_test_02 differences are due to PR #716 - my baseline regression tests were taken from commit feb333d where the gmake build was last working.

[aliabdolali]

@ukmo-ccbunney
I ran the tests with run_tests instead of run_cmake_test.
There are two types of failures. I have a fix for 1.

1. Could you do the following changes in regtests/bin/run_test

1262,1269c1262
< 
<         if [ $nml_input ] && [ ! -z "`ls ${path_i}/${prog}*.nml 2>/dev/null`" ]
<           then
<           inputs_tmp=`( ls ${path_i}/${prog}${gu}*nml)`
<          else
<           inputs_tmp=`( ls ${path_i}/${prog}${gu}*inp)`
<         fi
< 
---
>         inputs_tmp=`( ls ${path_i}/${prog}${gu}* )`

2. for ww3_tp2.14, we need to change the arguments in matrix.base to avoid the following:

 Create required model subdirectories

Finished setting up WAVEWATCH III

need four arguments:
$1 : path_i
$2 : path_w
$3 : switch
$4 : ww3_dir

ERROR: Error occured during WW3  build

to reproduce:
run_test -b slurm -o all -c hera.intel -S -T -s OASACM4 -i input_oasacm4 -w work_OASACM4 -C OASIS -f -p srun -n 24 ../model11 ww3_tp2.14

Could you check it?

[ukmo-ccbunney]

@aliabdolali - The issue with tp2.14 is that prep_env.sh now calls CMake regardless.
I think the only way around this is to have a separate prep_env_gmake.sh (or similar) script that provides the old functionality.

[aliabdolali]

@aliabdolali - The issue with tp2.14 is that prep_env.sh now calls CMake regardless. I think the only way around this is to have a separate prep_env_gmake.sh (or similar) script that provides the old functionality.

@ukmo-ccbunney I think we can skip it as gnu build is not used for our regtesting and gnu build will be retired soon.

[ukmo-ccbunney]

@aliabdolali - The issue with tp2.14 is that prep_env.sh now calls CMake regardless. I think the only way around this is to have a separate prep_env_gmake.sh (or similar) script that provides the old functionality.

@ukmo-ccbunney I think we can skip it as gnu build is not used for our regtesting and gnu build will be retired soon.

OK - I've pushed up the fix for run_test.

[JessicaMeixner-NOAA]

Regression test comparisons with cmake:
matrixDiff.txt
matrixCompFull.txt
matrixCompSummary.txt

are as expected:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UNO_MPI_d2                     (9 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
ww3_ta1/./work_UPD0F_U                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.17/./work_a                     (1 files differ)
ww3_tp2.17/./work_c                     (1 files differ)
ww3_tp2.17/./work_b                     (1 files differ)
ww3_tp2.6/./work_ST0                     (1 files differ)
ww3_tp2.6/./work_ST4                     (1 files differ)
ww3_tp2.6/./work_pdlib                     (1 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

The gnu make regression tests passed with the exception of the known issue of tp2.14