Skip to content

Cmake run_test and debug fixes#647

Merged
aliabdolali merged 3 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:bug/cmakeruntest
Mar 24, 2022
Merged

Cmake run_test and debug fixes#647
aliabdolali merged 3 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:bug/cmakeruntest

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Mar 24, 2022

Pull Request Summary

This provides a bug fix for CMAKE debug option when running with ufs-weather-model and makes sure when you are running with the -S option that run_cmake_test exists before building the code.

Description

Updates for cmake:

  • Fix from @kgerheiser for making sure CMAKE debug flags are cleared when WW3 is built from a parent repo, such as the ufs-weather-model
  • bug fix for run_cmake_test so that you will exit out before building the model if the -S option is used and the test has already been completed. This will make any resubmission of matrix regression tests significantly faster and was an oversight in the creation of run_cmake_test

Issue(s) addressed

-fixes #646

Commit Message

Update run_cmake test to exit if test is completed before building and clear debug flags in cmake if built from a parent repo.

co-author: @kgerheiser

Check list

Testing

  • How were these changes tested? The ufs-weather-model was run for the debug fix and then I ran the matrix, stopped after a test had completed, and then re-submitted the matrix to ensure that the test was then in fact skipped (before building) as expected.
  • Are the changes covered by regression tests? In the ufs-weather-model
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? no

@JessicaMeixner-NOAA JessicaMeixner-NOAA added the bug Something isn't working label Mar 24, 2022
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

@aliabdolali please let me know if you think the full matrix of regression tests are required for this PR so I can start those tests asap. In addition I'm happy to point you to testing I did with the cmake debug fix for ufs-waether-model that I did yesterday if that would be helpful for your review of this PR.

@aliabdolali
Copy link
Copy Markdown
Contributor

@jessica, the regtests are submitted this morning, please give me the path to the ufs tests. Also, I am happy with the changes, but let's wait for the tests.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

@aliabdolali aliabdolali merged commit d050d41 into NOAA-EMC:develop Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run_cmake_test does not skip build with -S option

2 participants