Cmake run_test and debug fixes#647
Merged
aliabdolali merged 3 commits intoMar 24, 2022
Merged
Conversation
Collaborator
Author
|
@aliabdolali please let me know if you think the full matrix of regression tests are required for this PR so I can start those tests asap. In addition I'm happy to point you to testing I did with the cmake debug fix for ufs-waether-model that I did yesterday if that would be helpful for your review of this PR. |
Contributor
|
@jessica, the regtests are submitted this morning, please give me the path to the ufs tests. Also, I am happy with the changes, but let's wait for the tests. |
aliabdolali
approved these changes
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This provides a bug fix for CMAKE debug option when running with ufs-weather-model and makes sure when you are running with the -S option that run_cmake_test exists before building the code.
Description
Updates for cmake:
Issue(s) addressed
-fixes #646
Commit Message
Update run_cmake test to exit if test is completed before building and clear debug flags in cmake if built from a parent repo.
co-author: @kgerheiser
Check list
Testing