Skip to content

Fix/add o all#645

Merged
aliabdolali merged 4 commits into
NOAA-EMC:developfrom
aliabdolali:fix/add_o_all
Mar 24, 2022
Merged

Fix/add o all#645
aliabdolali merged 4 commits into
NOAA-EMC:developfrom
aliabdolali:fix/add_o_all

Conversation

@aliabdolali
Copy link
Copy Markdown
Contributor

Pull Request Summary

add -o all to matrix*ncep

Description

The -o all option was supposed to be brought to the matrix files, but was not put in matrix*ncep or unintentionally dropped.

Please also include the following information:

Issue(s) addressed

  • Please list any issues associated with this PR, including those the PR will fix/close. For example:

Commit Message

add -o all option to matrix_cmake_ncep

Check list

Testing

  • How were these changes tested? to be updated
  • Are the changes covered by regression tests? n/a
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? Hera/intel
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt): to be updated
  • Please indicate the expected changes in the regression test output (Note the known list of non-identical tests).
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    to be updated

Comment thread regtests/bin/matrix_cmake_ncep
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

@aliabdolali I ran a similar branch and the diffs I got with the previous develop (ignoring the 0 diff entries) are:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (9 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (5 files differ)
ww3_tp2.14/./work_OASACM2                     (2 files differ)
ww3_tp2.14/./work_OASACM                     (2 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (2 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

I think it's okay to go ahead and merge this branch.

@aliabdolali
Copy link
Copy Markdown
Contributor Author

add -o all option to matrix_cmake_ncep

My requests are done with expected changes. Thanks for the parallel test.

@aliabdolali aliabdolali merged commit d1c10f3 into NOAA-EMC:develop Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-o all option needs to be added to matrix*ncep

2 participants