Fix/add o all#645
Merged
Merged
Conversation
JessicaMeixner-NOAA
approved these changes
Mar 24, 2022
Collaborator
|
@aliabdolali I ran a similar branch and the diffs I got with the previous develop (ignoring the 0 diff entries) are: I think it's okay to go ahead and merge this branch. |
Contributor
Author
My requests are done with expected changes. Thanks for the parallel test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
add
-o allto matrix*ncepDescription
The -o all option was supposed to be brought to the matrix files, but was not put in matrix*ncep or unintentionally dropped.
Please also include the following information:
Issue(s) addressed
Commit Message
add -o all option to matrix_cmake_ncep
Check list
Testing
to be updated