Skip to content

TOC total momentum to ocean added in documentation and nml/inp files#633

Merged
aliabdolali merged 1 commit into
NOAA-EMC:developfrom
ukmo-waves:bf_clarify_TOC
Mar 16, 2022
Merged

TOC total momentum to ocean added in documentation and nml/inp files#633
aliabdolali merged 1 commit into
NOAA-EMC:developfrom
ukmo-waves:bf_clarify_TOC

Conversation

@ukmo-nievesvaliente
Copy link
Copy Markdown
Collaborator

@ukmo-nievesvaliente ukmo-nievesvaliente commented Mar 8, 2022

Pull Request Summary

Total momentum to the ocean (TOC) has been added in the documentation and included in the nml and inp files where it was missing.

Description

The purpose is essentially to include TOC in the documentation ans add it as a field parameter in the inp/nml. Previous developments added the functionality of using/output TOC; however, this was not clear as the parameter was not included neither in the nml/inp nor the documentation.

Commit Message

TOC total momentum to ocean added in documentation and nml/inp files

Check list

Testing

  • How were these changes tested? N/A
  • Are the changes covered by regression tests? No, no changes were added to the source code.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? N/A
  • Please indicate the expected changes in the regression test output (Note the known list of non-identical tests). N/A
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):N/A

@ukmo-nievesvaliente ukmo-nievesvaliente marked this pull request as draft March 8, 2022 10:55
@ukmo-nievesvaliente ukmo-nievesvaliente marked this pull request as ready for review March 8, 2022 13:30
Copy link
Copy Markdown
Collaborator

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

Copy link
Copy Markdown
Collaborator

@ukmo-juan-castillo ukmo-juan-castillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@aliabdolali
Copy link
Copy Markdown
Contributor

The test ran as expected on NCEP HPC with intel.
Here is the summary, with just pre-known non-identical cases.

mww3_test_03/./work_PR2_UQ_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (9 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (8 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (5 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (2 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@aliabdolali aliabdolali merged commit 3f27304 into NOAA-EMC:develop Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants