TOC total momentum to ocean added in documentation and nml/inp files#633
Merged
Conversation
ukmo-ccbunney
approved these changes
Mar 8, 2022
Collaborator
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
All looks good to me.
ukmo-juan-castillo
approved these changes
Mar 9, 2022
Collaborator
ukmo-juan-castillo
left a comment
There was a problem hiding this comment.
Changes look good
aliabdolali
approved these changes
Mar 16, 2022
Contributor
|
The test ran as expected on NCEP HPC with intel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Total momentum to the ocean (TOC) has been added in the documentation and included in the nml and inp files where it was missing.
Description
The purpose is essentially to include TOC in the documentation ans add it as a field parameter in the inp/nml. Previous developments added the functionality of using/output TOC; however, this was not clear as the parameter was not included neither in the nml/inp nor the documentation.
Commit Message
TOC total momentum to ocean added in documentation and nml/inp files
Check list
Yes
done
documentation.
Testing