Fix Github Action builds#632
Merged
Merged
Conversation
Bring changes to the OASIS tests layout (ww3_tp2.14) to Github workflows.
Contributor
Author
|
Note this says there is one failing check, but it's an internal Github error. I re-ran it from my fork and it passed. Can't re-run in the main repo. |
JessicaMeixner-NOAA
approved these changes
Mar 8, 2022
aliabdolali
approved these changes
Mar 8, 2022
Collaborator
mickaelaccensi
left a comment
mickaelaccensi
left a comment
There was a problem hiding this comment.
even if it seems to work on my side, I don't catch why input directory is added in gnu.yml and similar files
| cmake . | ||
| make VERBOSE=1 | ||
| cp -r ${GITHUB_WORKSPACE}/ww3/regtests/ww3_tp2.14/work_oasis3-mct ${GITHUB_WORKSPACE} | ||
| cp -r ${GITHUB_WORKSPACE}/ww3/regtests/ww3_tp2.14/input/work_oasis3-mct ${GITHUB_WORKSPACE} |
Collaborator
There was a problem hiding this comment.
why have you added the input directory here ?
Contributor
Author
There was a problem hiding this comment.
Do I have it wrong? That's the location of work_oasis3-mct. I copy the work directory, which contains the built libraries to the top-level GITHUB_WORKSPACE and then cache it for future runs so it's not built during each run of the workflow.
- name: cache-env
id: cache-env
uses: actions/cache@v2
with:
path: |
spack
~/.spack
------> work_oasis3-mct
key: spack-${{ runner.os }}-${{ env.cache_key }}
aliabdolali
pushed a commit
that referenced
this pull request
Mar 16, 2022
Fix Github Action builds.
kestonsmith-noaa
pushed a commit
to kestonsmith-noaa/WW3
that referenced
this pull request
Jun 17, 2025
NOAA-EMC#632) * Add missing modulefile ufs_hera.gnu_debug; bug fix in tests/compile.sh when checking for DEBUG=Y * Thompson subcycling for develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Fix Github Action builds. The OASIS directory layout changed and the workflows had to be updated.
Description
The OASIS directory layout changed and the workflows had to be updated. Instead of using sed to find and replace the values in the makefile, use the environment variables directly.
@JessicaMeixner-NOAA @mickaelaccensi
Issue(s) addressed
Fix #631
Commit Message
Single commit that doesn't need to be squashed
Check list
Testing
The Actions complete successfully. See https://github.com/kgerheiser/WW3/actions/runs/1911148044