uniformize regtests output option

[mickaelaccensi]

Pull Request Summary

add option -o all in matrix_*
except for ukmo which is -o both
remove all -o statements in matrix.base
correct a test in run_test to avoid warnings

Description

uniformize the option -o to setup the kind of output type (ascii, netcdf, grib) in the main matrix script

Issue(s) addressed

• fixes uniformize matrix outputs #604

Commit Message

uniformize regtests output by setting a global output type in the matrix script

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested?
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  yes all
• Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  on going on datarmor with intel compiler
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
• Please indicate the expected changes in the regression test output (Note the known list of non-identical tests).
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

[JessicaMeixner-NOAA]

Thanks for making this a separate PR!

[JessicaMeixner-NOAA]

Started running the regtests so we can document what output changes and make sure everything runs if we are triggering any additional outputs.

[JessicaMeixner-NOAA]

So I got one error with the test:
in run_test -b slurm -o all -c hera.intel -S -T -w work_IC2IS2 ../model ww3_tic2.2

 *** WAVEWATCH III ERROR IN W3OUTP :
     ERROR IN READING FROM INPUT FILE
     LAST POINT INDEX IS NOT -1
     OR TOO MANY POINT INDEXES DEFINED

Did you have any issues with this test @mickaelaccensi ? I'm running the comparison now and will look into this error later today.

[mickaelaccensi]

So I got one error with the test: in run_test -b slurm -o all -c hera.intel -S -T -w work_IC2IS2 ../model ww3_tic2.2

 *** WAVEWATCH III ERROR IN W3OUTP :
     ERROR IN READING FROM INPUT FILE
     LAST POINT INDEX IS NOT -1
     OR TOO MANY POINT INDEXES DEFINED

Did you have any issues with this test @mickaelaccensi ? I'm running the comparison now and will look into this error later today.

yes, I've made the corrections and pushed them

[JessicaMeixner-NOAA]

The fix worked for me, running the matrix.comp now.

[JessicaMeixner-NOAA]

Only the known not b4b:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (9 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (8 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (5 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

Output:
matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt