allow mask variables to be retrieved from nems.configure#588
Merged
aliabdolali merged 1 commit intoJan 24, 2022
Merged
Conversation
* optionally retrieve maskvaluewater and maskvalueland if present in nems.configure
Contributor
|
The ufs-weather-model regtests have been successful on hera with the WW3/ufs-weather-model with these changes. |
aliabdolali
approved these changes
Jan 24, 2022
JessicaMeixner-NOAA
pushed a commit
to JessicaMeixner-NOAA/WW3
that referenced
this pull request
Jan 24, 2022
Retrieve mask_value_water and mask_value_land if present in nems.configure and med_present is true.
aliabdolali
pushed a commit
to aliabdolali/WW3
that referenced
this pull request
Jan 25, 2022
Retrieve mask_value_water and mask_value_land if present in nems.configure and med_present is true.
aliabdolali
pushed a commit
that referenced
this pull request
Jan 25, 2022
Retrieve mask_value_water and mask_value_land if present in nems.configure and med_present is true.
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Retrieves
mask_value_waterandmask_value_landif present in nems.configure andmed_presentis true.Description
Currently, when used in UWM, wmesmf sets the import and export mask values for the grid from the default values.
These values are opposite the normal interpretation and CMEPS is then forced to set the dstMaskValue and srcMaskValues used for RH creation opposite to their normal sense. In med_map_mod, the currently used values in CMEPS for HAFS are (
n1is the source side andn2is the destination side)Both the
dstMaskValuewhen the destination is compwav and thesrcMaskValuewhen compwav is the source are reversed. That is, the dstMaskValue should indicate where the wave grid is masked when it is the destination. It should be 0 (ie, don't interpolate to the land points). The srcMaskValue should indicate what points to ignore when wave is the source. It should be 0 (ie, don't interpolate from land points on the wave grid).When HAFS is switched to the new cap, the mask values will be set with the correct interpretation for CMEPS. A PR for CMEPS # 266 is the first step in implementing the new wave cap in UWM. In order for the existing cap to continue to work for HAFS, it is required to allow non-default mask values to be set from nems.configure:
These will be consistent with the
dstMaskValueandsrcMaskValueused by CMEPS.These configuration variables will not be added to the HAFS nems.configure in UWM until CMEPS is also updated.
Issue(s) addressed
This PR allows the current wmesmf cap to continue to function for UFS HAFS apps during the transition to a CMEPS cap for both S2SW and HAFS.
Commit Message
Retrieve mask_value_water and mask_value_land if present in nems.configure and med_present is true.
Check list
Testing
Baselines were run on both Cheyenne.intel and Cheyenne.gnu using a feature branch of CMEPS incorporating changes required for S2SW coupling. All baselines were B4B. Tested hash #f297618 of FB updcmeps_wavcpl