Skip to content

Memory leak: w3iorsmd.F90 #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aliabdolali merged 4 commits into from
Jan 24, 2022
Merged

Memory leak: w3iorsmd.F90 #583

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ba30e8
w3iorsmd: memory leak fix
MatthewMasarik-NOAA Jan 12, 2022
0b90be2
w3iorsmd: add needed logical var UNITOPEN
MatthewMasarik-NOAA Jan 12, 2022
c1a115a
w3iorsmd.F90: clean up fix
MatthewMasarik-NOAA Jan 14, 2022
6306b29
w3iorsmd: rename logical variable
MatthewMasarik-NOAA Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions model/src/w3iorsmd.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ SUBROUTINE W3IORS ( INXOUT, NDSR, DUMFPI, IMOD, FLRSTRT )

LOGICAL :: WRITE, IOSFLG
LOGICAL :: FLOGOA(NOGRP,NGRPP)
LOGICAL :: NDSROPN
CHARACTER(LEN=4) :: TYPE
CHARACTER(LEN=10) :: VERTST
! CHARACTER(LEN=21) :: FNAME
Expand Down Expand Up @@ -606,6 +607,13 @@ SUBROUTINE W3IORS ( INXOUT, NDSR, DUMFPI, IMOD, FLRSTRT )
#ifdef W3_T
WRITE (NDST,9005) TYPE
#endif
! Clean up file handles and allocated arrays
INQUIRE (UNIT=NDSR, OPENED=NDSROPN)
IF (NDSROPN) CLOSE(NDSR)
IF (ALLOCATED(WRITEBUFF)) DEALLOCATE(WRITEBUFF)
IF (ALLOCATED(TMP)) DEALLOCATE(TMP)
IF (ALLOCATED(TMP2)) DEALLOCATE(TMP2)

RETURN
ELSE IF ( IAPROC.LE.NAPROC .OR. IAPROC.EQ. NAPRST ) THEN
#ifdef W3_DEBUGIO
Expand Down Expand Up @@ -1479,9 +1487,13 @@ SUBROUTINE W3IORS ( INXOUT, NDSR, DUMFPI, IMOD, FLRSTRT )
!
! Close file --------------------------------------------------------- *
!
IF (WRITE) THEN
IF ( .NOT.IOSFLG .OR. IAPROC.EQ.NAPRST ) THEN
CLOSE ( NDSR )
END IF
ELSE
CLOSE ( NDSR )
END IF
!
#ifdef W3_DEBUGIO
WRITE(740+IAPROC,*) 'W3IORS, step 9'
Expand Down