[ww3_ounp] TIMESPLIT=0 support#569
Merged
Merged
Conversation
Contributor
|
The regtests ran fine except for the pre-known non-identical cases: |
aliabdolali
approved these changes
Jan 10, 2022
Contributor
|
@mickaelaccensi could you provide your review? Then we can merge it. |
mickaelaccensi
approved these changes
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Add TIMESPLIT=0 (no date string) support for
ww3_ounp, as perww3_ounfDescription
This PR adds support for a zero length datetime string (
TIMESPLIT=0in the namelist) forww3_ounp.This brings it in-line with ww3_ounf.
When TIMESPLIT=0, the output file will simply be
ww3.spec.ncfor combined files orww3.<field>_spec.ncfor split files.Commit Message
Add TIMESPLIT=0 (no date string) support for ww3_ounp.
Check list
Testing
Regression tests results
Full results: matrixComp_ounp_nodate.zip
Only the usual known non-b4b results: