Fix incorrect field index for ICEF#561
Conversation
|
I'll start running regtests here. The changes themselves look okay. Has someone grepped for ICEF or other variables to make sure we've gotten all the FLGRDALL( 1, 9) -> FLGRDALL( 1, 12) or would it be helpful if I did that as well? |
|
@ukmo-ccbunney @mickaelaccensi is this block of code okay as is: |
Good catch @JessicaMeixner-NOAA - that block of code needs changing. Also, I notice that RHOAIR and TAU are not output in ww3_outf; we should fix that! Are you happy if I do that in this PR? |
missing TAUA and RHOAIR outputs.
|
@ukmo-ccbunney that'd be great to add that to this PR, it all seems related to me. Thanks! |
OK - I've done that in the last commit. |
|
Thanks @ukmo-ccbunney I'll resubmit mine with the updates. |
|
Tests all run fine at NCEP, with just the expected differences: matrixCompFull.txt Thanks @ukmo-ccbunney for the updates. We're just waiting on @mickaelaccensi to review and then this is ready to be merged. |
mickaelaccensi
left a comment
mickaelaccensi
left a comment
There was a problem hiding this comment.
all good for me !
* Most GFSv14/GFSv15 based tests are updated to GFSv16 confiscation, the cold start ICs were created from GFSv16 anaylysis. A GDAS forecast case using IAU is also setup. * Debug tests are added for global regression tests * Regional tests was renamed, and regional threads was added * History file names are changed from "phyf/dynf" to operational file names "sfcf/atmf" * Restart files for baseline comparison are removed from the GFSv16 feature tests, only those tests with restart will still have restart files comparison * There is no change in non-GFS configuration tests using gsd, rrtf, hafs physics package * The first commit has no changes in cpld tests and datm tests. * The inline post issue in post interface post_*.F90 is fixed for gnu compiler. * amip_interp_nml namelist is removed from all the name list files * Unused configuration varaibles: cpl, memuse_verbose, atmos_nthreads, use_hyper_thread, ncores_per_node are removed from model_configure * The issue with inline post restart with gnu compiler is fixed * Input data directory input-data-20210528 has new 172 leves 2021032206 ICs for C96, C192 and C384 global input files. * utest related changes Co-authored-by: denise.worthen <Denise.Worthen@noaa.gov> Co-authored-by: MinsukJi-NOAA <Minsuk.Ji@noaa.gov> Co-authored-by: junwang-noaa <jun.wanag@noaa.gov>
3 participants
Pull Request Summary
The field index for
ICEFis incorrect inw3iorsmdandw3initmdDescription
The
ICEFindex is set as 9 in w3iorsmd and w3initmd, but it should be 12.This fix could result in a change in a generated restart file if
RHOwas requested as an extra restart output as this would have incorrectly output the "ICEF" field torestart.ww3.Currently, this only affects the ww3_tp2.14 regtest.
Issue(s) addressed
Commit Message
Fix incorrect field index for ICEF.
Check list
Testing
Regression test results: matrixComp_badfieldnum.zip
Summary of differences:
Expected differences: