Skip to content

[ww3_shel.nml] Fixed incorrect ordering of TAU and RHOAIR#559

Merged
JessicaMeixner-NOAA merged 1 commit into
NOAA-EMC:developfrom
ukmo-waves:bugfix/shelnml
Dec 15, 2021
Merged

[ww3_shel.nml] Fixed incorrect ordering of TAU and RHOAIR#559
JessicaMeixner-NOAA merged 1 commit into
NOAA-EMC:developfrom
ukmo-waves:bugfix/shelnml

Conversation

@ukmo-ccbunney
Copy link
Copy Markdown
Collaborator

@ukmo-ccbunney ukmo-ccbunney commented Dec 14, 2021

Pull Request Summary

Fixed incorrect ordering of TAU and RHOAIR fields in ww3_shel.nml field output table.

Description

The TAU and RHOAIR fields were incorrectly listed as fields 11 and 12 in ww3_shel.nml.
This has been corrected to reorder them as fields 8 and 9 as per w3iogomd.

This is a documentation change only so no regression tests have been run.

Issue(s) addressed

Commit Message

Fixed incorrect ordering of TAU and RHOAIR fields in ww3_shel.nml field output table.

Check list

Testing

  • How were these changes tested? Not required - documentation change only
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) N/A
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? N/A

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 59dd939 into NOAA-EMC:develop Dec 15, 2021
@mickaelaccensi
Copy link
Copy Markdown
Collaborator

I would think that it should be shifted to 11 and 12 otherwise it will make some inconsistencies like in w3iorsmd where field 9 is still linked to ICEF

          IF ( FLOGRR(1,9) )                                  &
            WRITE(NDSR,ERR=803,IOSTAT=IERR) ICEF(1:NSEA)

and in

w3initmd :

          IF ( FLOGRR(1,9) )                                  &
            WRITE(NDSR,ERR=803,IOSTAT=IERR) ICEF(1:NSEA)

@ukmo-ccbunney ukmo-ccbunney deleted the bugfix/shelnml branch December 15, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inconsistencies in group/field identifiers for RHO and TAU

4 participants