Skip to content

Bf test.comp#545

Merged
aliabdolali merged 32 commits into
NOAA-EMC:developfrom
aliabdolali:bf_test.comp
Nov 30, 2021
Merged

Bf test.comp#545
aliabdolali merged 32 commits into
NOAA-EMC:developfrom
aliabdolali:bf_test.comp

Conversation

@aliabdolali
Copy link
Copy Markdown
Contributor

Pull Request Summary

This PR adds:

  • ww3_tp2.2? to the regtests/bin/matrix.comp
  • extend regtests/bin/test.comp to include mutiple subdirectories and files under work directories.

Description

Is a change of answers expected from this PR? NA

Please also include the following information:

  • Add any suggestions for a reviewer @JessicaMeixner-NOAA
  • Mention any labels that should be added: bug

Issue(s) addressed

Commit Message

fix for test.comp and matrix.comp

Check list

Testing

  • How were these changes tested? NA
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) NA
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? NA

UKMO-lsampson and others added 30 commits July 22, 2020 11:44
to ensure they comply with the limits of the nameslist.
Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket #209
  * Additional CALTYPE namelist parameter in MISC section
  * New ww3_tc1 regtest.
* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole.
* Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.
Updates to allow a coupling time step that is different from the model time step. 
* Includes new regtest (in ww3_tp2.14) for non-default oasis time step.
* ww3_tp2.14 regtest added to matrix.base.
add missing ww3_tp2.2?
fix to include all sub directory files
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

Here's the output from matrix.comp:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (7 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (8 files differ)
mww3_test_07/./work_PR3_UQ                     (3 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_ufs1.1/./work_d                     (0 files differ)
ww3_ufs1.2/./work_b                     (0 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

Note, the tp2.1* tests are added to the identical list:

**********************************************************************
************************ identical cases *****************************
**********************************************************************
ww3_tp2.21/./work_b
ww3_tp2.21/./work_mb
ww3_tp2.21/./work_ma
ww3_tp2.21/./work_a

And the test compare looked at folders:

       *****************************************************************
     ***  compare WAVEWATCH III ww3_ufs1.2/work_a and ww3_ufs1.2/work_b  ***
       *****************************************************************

Warning: 20210401.030000.restart.aoc_9km is different
Warning: 20210401.030000.restart.gnh_10m is different
Warning: 20210401.030000.restart.gsh_15m is different
20210401.060000.restart.aoc_9km is identical
20210401.060000.restart.gnh_10m is identical
20210401.060000.restart.gsh_15m is identical
20210401.090000.restart.aoc_9km is identical
20210401.090000.restart.gnh_10m is identical
20210401.090000.restart.gsh_15m is identical
20210401.120000.restart.aoc_9km is identical
20210401.120000.restart.gnh_10m is identical
20210401.120000.restart.gsh_15m is identical
20210401.150000.restart.aoc_9km is identical
20210401.150000.restart.gnh_10m is identical
20210401.150000.restart.gsh_15m is identical
20210401.180000.restart.aoc_9km is identical
20210401.180000.restart.gnh_10m is identical
20210401.180000.restart.gsh_15m is identical
20210401.210000.restart.aoc_9km is identical
20210401.210000.restart.gnh_10m is identical
20210401.210000.restart.gsh_15m is identical
20210402.000000.restart.aoc_9km is identical
20210402.000000.restart.gnh_10m is identical
20210402.000000.restart.gsh_15m is identical
Warning: aoc_9km.grb2 is different
Warning: glo_15mxt.grb2 is different
Warning: gnh_10m.grb2 is different
Warning: gsh_15m.grb2 is different
Warning: out_grd.aoc_9km is different
Warning: out_grd.glo_15mxt is different
Warning: out_grd.gnh_10m is different
Warning: out_grd.gsh_15m is different
Warning: out_pnt.points is different
WHTGRIDINT.bin is identical
ww3.202104_tab.nc is identical
Warning: ww3_ounf_aoc_9km/ww3.202104.nc is different
Warning: ww3_ounf_glo_15mxt/ww3.202104.nc is different
Warning: ww3_ounf_gnh_10m/ww3.202104.nc is different
Warning: ww3_ounf_gsh_15m/ww3.202104.nc is different

Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests looks like all intended changes are there! Thanks @aliabdolali

@aliabdolali aliabdolali merged commit 3016ed3 into NOAA-EMC:develop Nov 30, 2021
@aliabdolali aliabdolali deleted the bf_test.comp branch January 24, 2022 14:45
kestonsmith-noaa pushed a commit to kestonsmith-noaa/WW3 that referenced this pull request Jun 17, 2025
…C#542), add CPLD&DATM tests on Jet (NOAA-EMC#545) (NOAA-EMC#533)


* update ufs-weather for removing nems mediator
* set mediator as cmeps in nems.configure*
* copy yaml field dictionary when runnning ATM,ATMW
* update NEMS and CMakeLists, nems.configure
* add a gcc module so that gfortran can be found when building
the WW3 switch preprocessing routines
* Add datm and coupled tests to Jet.

Co-authored-by: Jessica.Meixner <Jessica.Meixner@noaa.gov>
Co-authored-by: Bin.Li <bin.li@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

matrix.comp does not include ww3_tp2.2? tests test.comp does not handle subdirectories in work directories

5 participants