Skip to content

remove w3netcdf.F90 and associated debug messages that are not used#535

Merged
aliabdolali merged 2 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:cleanupnetcdf
Nov 22, 2021
Merged

remove w3netcdf.F90 and associated debug messages that are not used#535
aliabdolali merged 2 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:cleanupnetcdf

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Nov 16, 2021

Pull Request Summary

Clean up unused code

Description

This PR removes w3netcdf and a switch that is not actively used and was not transitioned to CPP

Issue(s) addressed

#528

Check list

Commit Message

  • remove unused w3netcdf code

Testing

  • How were these changes tested? full matrix
  • Are the changes covered by regression tests? the code was not used
  • If a new feature was added, was a new regression test added? no, removing unused/untested code
  • Have regression tests been run? yes
  • Which compiler / HPC you used to run the regression tests in the PR? matrix_ncep hera.intel
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

  • Just the normal not b4b diffs:
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (10 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (10 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (7 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (8 files differ)
mww3_test_07/./work_PR3_UQ                     (3 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (6 files differ)
ww3_ufs1.1/./work_d                     (0 files differ)
ww3_ufs1.2/./work_b                     (0 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)

…ly used

This was discovered as an oppertunity for cleanup for the cmake transition
@aliabdolali
Copy link
Copy Markdown
Contributor

The expected non-b4b cases

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (9 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (8 files differ)
mww3_test_07/./work_PR3_UQ                     (3 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (5 files differ)
ww3_ufs1.1/./work_d                     (0 files differ)
ww3_ufs1.2/./work_b                     (0 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)
 

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@aliabdolali aliabdolali merged commit 77319a1 into NOAA-EMC:develop Nov 22, 2021
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the cleanupnetcdf branch November 22, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants