Updates for Jet/HAFS#529
Merged
Merged
Conversation
JessicaMeixner-NOAA
requested review from
BinLiu-NOAA,
MatthewMasarik-NOAA and
aliabdolali
BinLiu-NOAA
approved these changes
Nov 12, 2021
BinLiu-NOAA
left a comment
BinLiu-NOAA
left a comment
There was a problem hiding this comment.
Thanks for fixing this quickly, @JessicaMeixner-NOAA!
My tests from the HAFS-WW3 side went through successfully on Jet.
Contributor
There was a problem hiding this comment.
I do not have access to Jet to verify, so will defer to @JessicaMeixner-NOAA and @aliabdolali .
aliabdolali
approved these changes
Nov 15, 2021
JessicaMeixner-NOAA
added a commit
that referenced
this pull request
Nov 17, 2021
Update for jet specific compiler flags
kestonsmith-noaa
pushed a commit
to kestonsmith-noaa/WW3
that referenced
this pull request
Jun 17, 2025
… consistent (NOAA-EMC#529) Substantial changes to CCPP physics to move surface emissivity/albedo calculation to its own scheme and to make surface roughness length composite consistent when fractional landmask is used. Updates to FV3GFS_io.F90 to write additional fields to the restart files (this requires removing the UGWPv1 warmstart test). Additional changes: Bug fixes for coupled model for GNU from @DeniseWorthen Bug fixes for 35-day runs from @DeniseWorthen Update for CI tests from @MinsukJi-NOAA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Add compiler specific flags for jet
Description
After issues that were discussed here: hafs-community/HAFS#107 (comment) it was determined that compiler specific flags were needed for jet.
Issue(s) addressed
Check list
Is your feature branch up to date with the authoritative repository (NOAA/develop)? yes
Make sure you have checked the checklist for a developer submitting to develop and updating version number
Please list appropriate labels code managers should add for this PR:
bug, documentation, enhancement, new feature, ..
Reviewers: @BinLiu-NOAA @aliabdolali @MatthewMasarik-NOAA
Commit Message
Testing
Please indicate the expected changes in the outputs (excluding the known list of non-identical tests).
mod_def change, out_grd change, out_pnt change, restart file change, Regression test, ...