Fb update issue temp#507
Conversation
to ensure they comply with the limits of the nameslist.
Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket #209 * Additional CALTYPE namelist parameter in MISC section * New ww3_tc1 regtest.
* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole. * Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.
Updates to allow a coupling time step that is different from the model time step. * Includes new regtest (in ww3_tp2.14) for non-default oasis time step. * ww3_tp2.14 regtest added to matrix.base.
This reverts commit 6efe9bb.
update feature request tmp
update doc tmp
update bug report tmp
|
I think this is better since there is not an added text to each issue template. However, I'm still curious as to what this will look like for when someone goes to the issues page. |
From what I searched, there is no way to see it until it is merged. It is following the example (github/feedback#2858), so we can merge and see. |
|
Interested to hear @ukmo-ccbunney thoughts before approving. |
|
Something I am not clear on here - is this the text that will appear when the "Issues" tab is selected, or when we create a "New Issue"? I imagined that we would have extra entries in the "New Issue" page that would direct users to the discussion section if they wanted to ask about general model run questions, etc. E.g. something with a button that links to this URL: https://github.com/NOAA-EMC/WW3/discussions/new?category=q-a in addition to the existing new "Issue" buttons. Maybe I am misunderstanding something here? |
@ukmo-ccbunney It will be like this: when you click on a new issue, it will give you four options for issues (GET STARTED) and a couple of OPEN icons, linked to the discussion (see this example). |
|
Maybe I can make a fake repo and add this in to see exactly what it would look like. |
|
@aliabdolali @ukmo-ccbunney here's a preview of what this would look like: |
|
Here's a screen shot: I'm going to test a few changes with this repo. If you want to test others, just make a temporary repo in GitHub and copy in the .github directory from WW3 here or you could probably just change your default branch on your fork to your test branch to see the changes in retrospect... |
|
Okay, here's my alternative suggestion for the issue page: and I also modified the PR template, see preview: |
|
Great - that looks good @JessicaMeixner-NOAA https://github.com/NOAA-EMC/WW3/discussions/new?category=q-a Or perhaps we prefer to just send users to the Discussion/q-a page first so they can check whether their question has already been answered? Either way, I like the new Issue template. |
|
@aliabdolali I made a PR to your branch here: https://github.com/aliabdolali/WW3/pull/2 Should I add the suggestions I had for the PR template to that branch or should I create a new PR? |
Can you make a PR to my PR or I can manually do it, either way, works for me. |
…pdate update to issue templates
|
@ukmo-ccbunney thanks for the feedback. hope we get fewer user support requests in the issue section. |
|
The PR updates are here: https://github.com/aliabdolali/WW3/pull/3 |
update to PR template
JessicaMeixner-NOAA
left a comment
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
I approve, but let's wait for @ukmo-ccbunney's approval before merging.
ukmo-ccbunney
left a comment
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Looks great to me!
It's a shame we can't get the "Discussion" buttons to look the same as the "Issue" buttons, but I think that is a GitHub issue that some other users have raised.
…itial, ocn -> wat, merra2 threading (NOAA-EMC#520) * changed .gitmodules to point to merra2 fv3atm * Update .gitmodules and submodule pointer for fv3atm for code review and testing * update submodule pointer for fv3atm * Update regression test baseline date in tests/rt.sh; run-ci * RT JOBS PASSED: hera.gnu. Log file uploaded. * RT JOBS PASSED: gaea.intel. Log file uploaded. * RT JOBS PASSED: hera.intel. Log file uploaded. * RT JOBS PASSED: orion.intel. Log file uploaded. * Regression test logs for wcoss_dell_p3 and wcoss_cray * Regression test logs for cheyenne.gnu * Regression test logs for cheyenne.intel * Regression test log for jet.intel * Revert change to .gitmodules and update submodule pointer for fv3atm Co-authored-by: anning.cheng <anning.cheng@noaa.gov> Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
5 participants
Pull Request Summary
This PR updates the issue and pull request templates and refers users related questions to the discussion section.
Description
Provide a detailed description of what this PR does. update issue templates.
What bug does it fix, or what feature does it add? NA
Is a change of answers expected from this PR? NA
Issue(s) addressed
coauthor: @JessicaMeixner-NOAA
Check list
Commit Message
Testing