Bugfix/FLX5 Tau

[ukmo-ccbunney]

Pull Request Summary [SEE #499]

Fixes order of parameters in W3SRCE subroutine definition when compiled with FLX5 switch.

Description

During the addition of the !/FLX5 flags to PR #483 I unintentionally altered the order of the parameters in the subroutine definition of W3SRCE in w3srcemd.

The model still compiles and runs, but the results are incorrect.

This only affects models compiled with the FLX5 switch and didn't show up in the regression tests as there was no existing FLX5 test.

Check list

• Is your feature branch up to date with the authoritative repository (NOAA/develop)? yes
• Make sure you have checked the checklist for a developer submitting to develop and updating version number

Commit Message

• Please provide a short summary of this PR, which will be used during Squash and Merge and will be shown as git log message

Testing

• How were these changes tested? Regtests, local testing with known good output.
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) yes
• If a new feature was added, was a new regression test added? n/a
• Have regression tests been run? Yes
• Which compiler / HPC you used to run the regression tests in the PR? Cray HPC; GNU compiler

Regression tests results:
matrix_flx5_tau.zip

Summary:

Usual issues with mww3_test_03.
ww3_tp2.15: The two FLX5 tests are different (as expected).

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (9 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (13 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (11 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
ww3_tp2.15/./work_ST4FLX5                     (5 files differ)
ww3_tp2.15/./work_ST6FLX5                     (5 files differ)

[ukmo-nievesvaliente]

The bug has been corrected and the switch works fine now.

[ukmo-ccbunney]

This PR will be merged via the UKMO Staging Branch; see #499