Skip to content

Remove support for compiler directive switches#386

Merged
aliabdolali merged 9 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:feature/removecompilerspecificswitches
Jun 11, 2021
Merged

Remove support for compiler directive switches#386
aliabdolali merged 9 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:feature/removecompilerspecificswitches

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented May 27, 2021

Pull Request Summary

Remove support for compiler directive switches ( C90, NEC, SX6, SX8).

Description

This PR removes support for compiler directive switches ( C90, NEC, SX6, SX8), which were originally used when certain compilers in the past did not handle various aspects for either OMP or other needed code. These work arounds have not been used for a long time and are being removed. There is no expectation of any answer changes for regression tests.

Issue(s) addressed

Testing

  • The regression tests matrix_ncep were run using hera.intel and no errors were found. The regression tests need to be rerun and checked (no expectation that anything other than the normal not-b4b tests will be different) when it's merged with the top of develop pre-commit. At that time, the matrix results will be posted.

aliabdolali
aliabdolali reviewed Jun 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@aliabdolali aliabdolali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The followings still need clean up:
model//ftn/w3pro2md.ftn:581:! !/NEC Enable NEC SXF90 compiler directives.
model//ftn/w3pro1md.ftn:368:! !/NEC Enable NEC SXF90 compiler directives.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

JessicaMeixner-NOAA commented Jun 10, 2021

The followings still need clean up:
model//ftn/w3pro2md.ftn:581:! !/NEC Enable NEC SXF90 compiler directives.
model//ftn/w3pro1md.ftn:368:! !/NEC Enable NEC SXF90 compiler directives.

Good catch! Since these are commented out, I'm assuming you will be okay if I do not restart regression tests. If you want me to, just let me know and I'll restart them now. They are almost done running now.

@aliabdolali
Copy link
Copy Markdown
Contributor

aliabdolali commented Jun 10, 2021

The followings still need clean up:
model//ftn/w3pro2md.ftn:581:! !/NEC Enable NEC SXF90 compiler directives.
model//ftn/w3pro1md.ftn:368:! !/NEC Enable NEC SXF90 compiler directives.

Good catch! Since these are commented out, I'm assuming you will be okay if I do not restart regression tests. If you want me to, just let me know and I'll restart them now. They are almost done running now.

No need to rerun the tests due to the reason you mentioned.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

JessicaMeixner-NOAA commented Jun 10, 2021

Updated per review. Let me know if that's not correct.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator Author

JessicaMeixner-NOAA commented Jun 11, 2021

Only the usual regtests did not pass:
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@aliabdolali I believe this PR is ready for your final review

@aliabdolali aliabdolali merged commit 569e25d into NOAA-EMC:develop Jun 11, 2021
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the feature/removecompilerspecificswitches branch June 11, 2021 20:58
kestonsmith-noaa pushed a commit to kestonsmith-noaa/WW3 that referenced this pull request Jun 17, 2025
@climbfuji
Update develop from NOAA-GSL: RUC ice, MYNN sfclay, stochastic land p…
ea8a7aa 
…erturbations (NOAA-EMC#386)

* Update .gitmodules and submodule pointer for fv3atm for gsl/develop branch
* RUC ice for gsl/develop (replaces NOAA-EMC#47) (NOAA-EMC#49)Implementation of RUC LSM ice model in CCPP
* Squash-merge climbfuji:rucice_gfsv16dzmin into gsl/develop
* Add kice=9 to tests/tests/fv3_ccpp_rap and tests/tests/fv3_ccpp_hrrr
* Change NEW_BASELINE directory for gsl/develop to avoid conflicts with development work on the authoritative branches
* Add KICE=9 to tests/tests/fv3_ccpp_gsd_unified_ugwp and tests/tests/fv3_ccpp_gsd_drag_suite_unified_ugwp
* Revert change to .gitmodules and update submodule pointer for fv3atm
* Update gsl/develop from develop 2020/12/08 (NOAA-EMC#50)
* Updates to stochastic_physics_wrapper (NOAA-EMC#280)
Fix to stochastic_physics_wrapper to allow for random patterns to update at a longer time-step than model
* Update for Jet, bug fixes in running with frac_grid=T and GFDL MP, and in restarting with frac_grid=T  (NOAA-EMC#304)
Update the modulefile for jet.intel to enable UPP v10.0.0. The hpc-stack v1.0.0 pre-release is used for this. Small changes are made to tests.rt.sh for jet.intel and gaea.intel (consistency with other platforms).
The submodule pointer update for fv3atm addresses bugs in the ufs-weather-model with frac_grid=T and GFDL microphysics, and with restarting the model when frac_grid=T (from @shansun6 and @SMoorthi-emc).
* Land stochastic perturbations (NOAA-EMC#57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aliabdolali aliabdolali aliabdolali approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove support for compiler directive switches ( C90, NEC, SX6, SX8)

2 participants

@JessicaMeixner-NOAA @aliabdolali