Bug fixes for z0 over ice for ESMF cap #248
Merged
aliabdolali merged 3 commits intoSep 4, 2020
Merged
Conversation
Collaborator
Author
|
Regression tests passed on hera and orion for ufs-s2s-model after creation of new baselines. See: ufs-community/ufs-s2s-model#171 for details. There is no expected impact on any standalone WW3 regression tests. |
aliabdolali
approved these changes
Sep 4, 2020
Contributor
aliabdolali
left a comment
aliabdolali
left a comment
There was a problem hiding this comment.
It looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A value of z0 was put over ice, however this was not correct and was done in attempt to fix other issues. However, this caused it's own issues and is now being removed.
This also addressed: