Skip to content

Fix compiler remarks in WW3 and operational workflow when using debug build#1558

Merged
JessicaMeixner-NOAA merged 7 commits into
NOAA-EMC:developfrom
mingchen-NOAA:ww3/rmRemarksP6
Jan 26, 2026
Merged

Fix compiler remarks in WW3 and operational workflow when using debug build#1558
JessicaMeixner-NOAA merged 7 commits into
NOAA-EMC:developfrom
mingchen-NOAA:ww3/rmRemarksP6

Conversation

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

@mingchen-NOAA mingchen-NOAA commented Jan 24, 2026

Pull Request Summary

This PR silences compiler “remark” in modules w3tidemd, w3updtmd, w3wavemd, and w3srcemd resulting in cleaner WW3/GFS debug builds.

Description

This PR partially resolves compiler remarks in WW3 and the operational workflow during debug build by addressing remark #7712 (“variable has not been used”): unused variables were removed from source codes: w3tidemd.F90 w3updtmd.F90 w3wavemd.F90 w3srcemd.F90.

Issue(s) addressed

Addressing #1501

Commit Message

Remove compiler remarks in modules w3tidemd, w3updtmd, w3wavemd, and w3srcemd

Check list

Testing

  • How were these changes tested? Matrix
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? Ursa Intel and GNU
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

Ursa Intel:


********************* non-identical cases ****************************


mww3_test_03/./work_PR3_UNO_MPI_d2 (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR1_MPI_d2 (17 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (17 files differ)
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_09/./work_MPI_ASCII (0 files differ)
ww3_tp2.10/./work_MPI_OMPH (6 files differ)
ww3_tp2.6/./work_ST4_ASCII (0 files differ)
ww3_ufs1.3/./work_a (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Ursa GNU:


********************* non-identical cases ****************************


mww3_test_03/./work_PR3_UNO_MPI_d2 (15 files differ)
mww3_test_03/./work_PR1_MPI_d2 (12 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (3 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (16 files differ)
mww3_test_09/./work_MPI_ASCII (0 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.16/./work_MPI_OMPH (4 files differ)
ww3_tp2.6/./work_ST4_ASCII (0 files differ)
ww3_ufs1.3/./work_a (27 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator Author

UFSWM full RT tests passed on Ursa.
/scratch4/NCEPDEV/marine/Ming.Chen/ufs_wm/ursa/rmRemarks/tests

Note:
failed case control_p8_ugwpv1_tempo_aerosol_hail intel does not contain wave model.

Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (20 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ts3/./work_ST1_PR1_MPI_OMPH                     (1 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

Thank you @mingchen-NOAA !

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit f8cff11 into NOAA-EMC:develop Jan 26, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants