Skip to content

Remove goto statements in wav_shel_in.F90#1551

Merged
JessicaMeixner-NOAA merged 1 commit into
NOAA-EMC:dev/ufs-weather-modelfrom
mingchen-NOAA:ufs_wm/rmGoTo
Jan 12, 2026
Merged

Remove goto statements in wav_shel_in.F90#1551
JessicaMeixner-NOAA merged 1 commit into
NOAA-EMC:dev/ufs-weather-modelfrom
mingchen-NOAA:ufs_wm/rmGoTo

Conversation

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

Pull Request Summary

Remove gotos in wav_shel_in.F90.

Description

This PR removes the remaining goto statements in wav_shel_in.F90.
No change of answers is expected after this change.

Issue(s) addressed

fixes #1487

Commit Message

Remove goto statements in wav_shel_in.F90

Check list

Testing

  • How were these changes tested? UFSWM full RT passed
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? Ursa
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator Author

UFSWM RT tests PASSED on Ursa
/scratch4/NCEPDEV/marine/Ming.Chen/ufs_wm/ursa/rmGoTo/tests

Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mingchen-NOAA for fixing this!

@gspetro-NOAA
Copy link
Copy Markdown

Testing on WM parent PR 3040 completed successfully. This PR can be merged.

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit ae1db52 into NOAA-EMC:dev/ufs-weather-model Jan 12, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants