Fix non-B4B issue in ww3_tp2.1 by using separate output filenames for dual postprocessing steps#1546
Merged
JessicaMeixner-NOAA merged 2 commits intoDec 5, 2025
Conversation
JessicaMeixner-NOAA
approved these changes
Dec 5, 2025
Collaborator
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
Because of changes here, we have the expected changes:
ww3_tp2.1/./work_PR2_UQ (2 files differ)
ww3_tp2.1/./work_PR1 (2 files differ)
ww3_tp2.1/./work_PR2_UQ_MPI (2 files differ)
ww3_tp2.1/./work_PR1_MPI (2 files differ)
ww3_tp2.1/./work_PR3_UQ (2 files differ)
ww3_tp2.1/./work_PR3_UQ_MPI (2 files differ)
ww3_tp2.1/./work_PR3_UNO (2 files differ)
ww3_tp2.1/./work_PR3_UNO_MPI (2 files differ)
ww3_tp2.1/./work_PR2_UNO_MPI (2 files differ)
ww3_tp2.1/./work_PR2_UNO (2 files differ)
and then the normal tests:
**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (15 files differ)
mww3_test_03/./work_PR1_MPI_d2 (18 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (17 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2 (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c (1 files differ)
mww3_test_03/./work_PR1_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (14 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c (1 files differ)
mww3_test_09/./work_MPI_ASCII (0 files differ)
ww3_tp2.10/./work_MPI_OMPH (7 files differ)
ww3_tp2.16/./work_MPI_OMPH (1 files differ)
ww3_tp2.6/./work_ST4_ASCII (0 files differ)
ww3_ufs1.3/./work_a (2 files differ)
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR fixes an issue where the regression test ww3_tp2.1 occasionally produces a non-B4B differences in the output file ww3.196806.nc.
Description
To prevent the two NetCDF post-processing steps from generating output files with the same filename, the output filename in
ww3_ounf_flds_hrly.inphas been updated to use an 8-character name. This ensures it remains distinct from the output produced byww3_ounf.inp, avoiding accidental overwrites.The output file
ww3.196806.ncis now generated exclusively byww3_ounf.inp, whileww3.19680606.ncis produced byww3_ounf_flds_hrly.inp, ensuring the two post-processing steps no longer overwrite each other.The following work outputs may differ from those in the current develop branch, depending on which post-processing step is executed first.
Issue(s) addressed
fixes #1545
Commit Message
Fix non-B4B issue in ww3_tp2.1 by using separate output filenames for dual postprocessing steps
Check list
Testing
Compared to the current develop branch:
matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt