Skip to content

Fix non-B4B issue in ww3_tp2.1 by using separate output filenames for dual postprocessing steps#1546

Merged
JessicaMeixner-NOAA merged 2 commits into
NOAA-EMC:developfrom
mingchen-NOAA:ww3/fixNonB4B_tp2.1
Dec 5, 2025
Merged

Fix non-B4B issue in ww3_tp2.1 by using separate output filenames for dual postprocessing steps#1546
JessicaMeixner-NOAA merged 2 commits into
NOAA-EMC:developfrom
mingchen-NOAA:ww3/fixNonB4B_tp2.1

Conversation

@mingchen-NOAA
Copy link
Copy Markdown
Collaborator

@mingchen-NOAA mingchen-NOAA commented Dec 4, 2025

Pull Request Summary

This PR fixes an issue where the regression test ww3_tp2.1 occasionally produces a non-B4B differences in the output file ww3.196806.nc.

Description

To prevent the two NetCDF post-processing steps from generating output files with the same filename, the output filename in ww3_ounf_flds_hrly.inp has been updated to use an 8-character name. This ensures it remains distinct from the output produced by ww3_ounf.inp, avoiding accidental overwrites.

The output file ww3.196806.nc is now generated exclusively by ww3_ounf.inp, while ww3.19680606.nc is produced by ww3_ounf_flds_hrly.inp, ensuring the two post-processing steps no longer overwrite each other.

The following work outputs may differ from those in the current develop branch, depending on which post-processing step is executed first.

ww3_tp2.1/./work_PR2_UNO 
ww3_tp2.1/./work_PR1_MPI 
ww3_tp2.1/./work_PR3_UNO_MPI  
ww3_tp2.1/./work_PR2_UQ 
ww3_tp2.1/./work_PR2_UNO_MPI 
ww3_tp2.1/./work_PR3_UNO  
ww3_tp2.1/./work_PR3_UQ_MPI 
ww3_tp2.1/./work_PR1 
ww3_tp2.1/./work_PR3_UQ 
ww3_tp2.1/./work_PR2_UQ_MPI

Issue(s) addressed

fixes #1545

Commit Message

Fix non-B4B issue in ww3_tp2.1 by using separate output filenames for dual postprocessing steps

Check list

Testing

  • How were these changes tested? Matrix
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)? Ursa Intel
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

Compared to the current develop branch:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UNO_MPI_d2                     (19 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.1/./work_PR2_UNO                     (2 files differ)
ww3_tp2.1/./work_PR1_MPI                     (2 files differ)
ww3_tp2.1/./work_PR3_UNO_MPI                     (2 files differ)
ww3_tp2.1/./work_PR2_UQ                     (2 files differ)
ww3_tp2.1/./work_PR2_UNO_MPI                     (2 files differ)
ww3_tp2.1/./work_PR3_UNO                     (2 files differ)
ww3_tp2.1/./work_PR3_UQ_MPI                     (2 files differ)
ww3_tp2.1/./work_PR1                     (2 files differ)
ww3_tp2.1/./work_PR3_UQ                     (2 files differ)
ww3_tp2.1/./work_PR2_UQ_MPI                     (2 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (2 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of changes here, we have the expected changes:

ww3_tp2.1/./work_PR2_UQ                     (2 files differ)
ww3_tp2.1/./work_PR1                     (2 files differ)
ww3_tp2.1/./work_PR2_UQ_MPI                     (2 files differ)
ww3_tp2.1/./work_PR1_MPI                     (2 files differ)
ww3_tp2.1/./work_PR3_UQ                     (2 files differ)
ww3_tp2.1/./work_PR3_UQ_MPI                     (2 files differ)
ww3_tp2.1/./work_PR3_UNO                     (2 files differ)
ww3_tp2.1/./work_PR3_UNO_MPI                     (2 files differ)
ww3_tp2.1/./work_PR2_UNO_MPI                     (2 files differ)
ww3_tp2.1/./work_PR2_UNO                     (2 files differ)

and then the normal tests:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (18 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (14 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (17 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (1 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (2 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit a55d642 into NOAA-EMC:develop Dec 5, 2025
22 checks passed
@mingchen-NOAA mingchen-NOAA deleted the ww3/fixNonB4B_tp2.1 branch January 13, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ww3_tp2.1 occasionally produces a non-b4b difference in the file ww3.196806.nc

2 participants