Use ymd instead of uninitialized date in timeInit for (unused?) optDate in alarmInit

[NickSzapiro-NOAA]

Pull Request Summary

Address compiler warning and bug that Warning: 'date' is used uninitialized [-Wuninitialized]

Description

This impacts alarmInit when using optDate. I don't know that anyone does that, especially as it's not working properly.

labels: bug

Issue(s) addressed

Part of ufs-community/ufs-weather-model#2703

Commit Message

Use ymd instead of uninitialized date in timeInit for (unused?) optDate in alarmInit

Solution by @DeniseWorthen

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested?
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
• Have the matrix regression tests been run (if yes, please note HPC and compiler)?
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

[JessicaMeixner-NOAA]

@NickSzapiro-NOAA these changes look very straightforward and I saw the comments from @DeniseWorthen suggesting this fix in the other thread. I'm assuming the UFS regression tests are sufficient for these changes? We don't need any workflow tests or things like that? The standalone WW3 tests are not applicable here so I will not run them.

[NickSzapiro-NOAA]

The UFS regression tests don't use this option, so I'm not sure they're applicable either

[JessicaMeixner-NOAA]

Is there any testing we need to do? If so, let me know. Otherwise I'm okay w/approving this PR - but if there's tests we should run or whatever I'm happy to help.

[DeniseWorthen]

We'll need to run the UWM RTs when this comes in (here and in CICE), but I see no reason to run any standalone RTs prior to that.

[NickSzapiro-NOAA]

I don't know if we should check that the alarm has the proper effect for optDate. For me, idea is to fix compiler warning

[JessicaMeixner-NOAA]

Thanks @DeniseWorthen

[JessicaMeixner-NOAA]

Approve assuming all the UFS tests pass.

[DeniseWorthen]

@NickSzapiro-NOAA Thanks for making this fix. I'm concerned about the one in fld1md that is using **(3/2). Have you tested if changing that to **(1.5) changes answers?

[NickSzapiro-NOAA]

I can do that one next...I assume **1 vs **1.5 has to change answers.