master HotFix: ounfpart + NCO switch + DB1 coeff (v6.07.1)#14
Merged
Conversation
Merging hotfix branch ukmo-waves:HF_ounfpart -> NOAA-EMC/WW3:HF_ounfpart: * Bugfix in ww3_ounf.ftn: NBIPART check against NOSWLL was not accouting for zeroth wind partition. See Issue #2. * Updated comments * Moved broken ww3_grid*.nml files into subdirectory within input dir. Updated info to stress that test needs to be run with -N flag.
Accepting HF that contains several changes needed for version 6.07 to work for NCEP applications: * Branch HF_NCOswitch_ndso: Changing README.md TM->R, adding grib2 link options to link, creating switch for GLWU, changing w3_make to allow grib compilation * Branch HF_NCOswitch_ndso: Updating link.wcoss_phase2 for grib compile, fixing OMPH OMPG switch flags that broke uprstr compilation, added new global wave model switch * Branch HF_NCOswitch_ndso: reverting change in ounf that belongs to UKMO branch
Adding bugfix to depth breaking DB1. * breaking_bugfix: add proper scaling for radian freq. [radHz] * breaking_bugfix: Add some comments ... * update comments ... * update comments ... * changed version number in header from 7.00 to 6.07 * minor formatting fix on header
ajhenrique
changed the title
aliabdolali
pushed a commit
that referenced
this pull request
Sep 25, 2020
* Fb rtd2 (#7) FB_rtd2: Output boundary conditions to rotated grids * This feature allows the user to specify the pole of each nested grid output of boundary conditions (nest) file. - There is no effect unless the switch RTD is set for compilation. - The contents of b.c. output files nestI.ww3 are not affected. - A model compiled with combined switches SMC and RTD is not affected. * Updated manual Sec. "3.4.9 Rotated grids" * Added regtests for testing input/output BCs in rotated pole context. * Updated revision of ww3_bound.ftn to 7.11 * Added new ww3_tr1 regtest (rotated pole) to matrix.base. Also, split the SMC/RTD regtests into their own separate switches. Co-authored-by: ukmo-chris.bunney <christopher.bunney@metoffice.gov.uk> * Double allocation error of FIELD variable [w3wavemd] (#14) * Fixed allocation of FIELD variable. * Removed defunct OMPX switches and FLOMP variable * Change coupling condition so that it works with all compilers (#12) Co-authored-by: Carsten Hansen <cha@fcoo.dk> Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com>
MatthewMasarik-NOAA
pushed a commit
that referenced
this pull request
Oct 18, 2023
* ensure lat array, for the loop, is ok while dowloading AODN data in the Southern Hemisphere. * SENTINEL-3B included. Longitude standard checked * fixed long issues * header text improved
mvertens
pushed a commit
to mvertens/WW3
that referenced
this pull request
Jul 25, 2024
always expect 10m winds to ww3 from CMEPS
kestonsmith-noaa
pushed a commit
to kestonsmith-noaa/WW3
that referenced
this pull request
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HF ounfpart integrates hotfixes from the NCEP/NOAA-EMC auth repo and the trusted repos UKMO and ERDC. The following hotfixes are implemented with this pull request:
Hotfixes were tested using the full regression testing matrix at NCEP which resulted in differences only in regtests wher DB1 was employed, as expected.